Jaunty SRU - LP364678 - UBUNTU: Sony laptop: Some Sony Vaia laptops do not enable wwan power by default.

Tim Gardner tim.gardner at canonical.com
Wed Apr 22 19:04:24 UTC 2009


Stefan Bader wrote:
> Tim Gardner wrote:
>> The following changes since commit a63b7d7beeaa1f8f33369cab6419831fa8991e40:
>>   Tyler Hicks (1):
>>         UBUNTU: SAUCE: (drop after 2.6.28) [PATCH] eCryptfs: Larger buffer for encrypted symlink targets
>>
>> are available in the git repository at:
>>
>>   git://kernel.ubuntu.com/rtg/ubuntu-jaunty lp364678
>>
>> Tim Gardner (1):
>>       UBUNTU: Sony laptop: Some Sony Vaia laptops do not enable wwan power by default.
>>
>>  drivers/misc/sony-laptop.c |   24 +++++++++++++++++++++++-
>>  1 files changed, 23 insertions(+), 1 deletions(-)
>> From 083972abb1d5e84845927b3925f077953c207b82 Mon Sep 17 00:00:00 2001
>> From: Tim Gardner <tim.gardner at canonical.com>
>> Date: Tue, 21 Apr 2009 11:09:10 -0600
>> Subject: [PATCH] UBUNTU: Sony laptop: Some Sony Vaia laptops do not enable wwan power by default.
>>
>> Bug: #364678
>>
>> Added quirk to enable wwan power based on DMI information already present in the module.
>>
>> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
>> ---
>>  drivers/misc/sony-laptop.c |   24 +++++++++++++++++++++++-
>>  1 files changed, 23 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
>> index 7e73acc..eab7011 100644
>> --- a/drivers/misc/sony-laptop.c
>> +++ b/drivers/misc/sony-laptop.c
>> @@ -1248,10 +1248,13 @@ struct device_ctrl {
>>  	u16				evport_offset;
>>  	u8				has_camera;
>>  	u8				has_bluetooth;
>> -	u8				has_wwan;
> 
> Is that necessary? There seems to be no code that removes it somewhere else.
> 
> Rest looks ok. Maybe tag SAUCE? For Karmic I assume it goes into the "I want 
> get upstreamed" place.

yeah, 'has_wwan' isn't used anywhere, but I probably shouldn't have
removed it in this commit. I'm reworking this patch for upstream since
sony-laptop.c has moved to drivers/platform/x86 in Karmic. I'll send a
v2 with 'has_wwan' left alone.

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list