[PATCH 3/4] UBUNTU: Add lenovo-sl-laptop in backport package

Stefan Bader stefan.bader at canonical.com
Tue Apr 21 17:51:42 UTC 2009


Tim Gardner wrote:
> Stefan Bader wrote:
>> I would apply your series with patch 3 replaced by this one (as the
>> series did not compile in my chroot due to the uname -r call. I also
>> would think this form is more like the additions looked in older
>> releases. Is that ok with you?
>> (I reordered the patches 1,2 and 4 to be 1-3 and this one, which enables
>> the driver to be 4)
>>
>> Stefan
>>
> 
> For Karmic I collapsed and reordered the patches thusly:
> 
> 3efeb865513962ae8e99f2e215cfad1908f08671 UBUNTU: SAUCE:
> lenovo-sl-laptop: Remove proc_dir_entry::owner setting
> 6ecfa3b9eb008c39744dc693bd294694996e3893 UBUNTU: SAUCE: Add dmi pattern
> for Lenovo SL laptop
> 1b0cd8210f32e98ac92070766012eb6a65d4c69c UBUNTU: Add lenovo-sl-laptop as
> Ubuntu third-party drivers
> 
> The original patch to initially add the driver had a non-functional
> Makefile, which is why I squashed the next patch which fixed the
> Makefile as well as added config options. Doing it that way makes the
> tree compilable at every bisect point.
> 
> rtg

That might be an alternate option. The way now patches 1-3 are just adding a 
new directory which is not build. Only the last patch adds that and enables the 
build. So the tree is also compilable at all stages.

-- 

When all other means of communication fail, try words!






More information about the kernel-team mailing list