Karmic - Revert "UBUNTU: SAUCE: hotkey quirks for various Zeptro Znote and Fujitsu Amilo laptops"

Stefan Bader stefan.bader at canonical.com
Wed Apr 15 15:42:55 UTC 2009


Tim Gardner wrote:
> Stefan Bader wrote:
>> Tim Gardner wrote:
>>> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-karmic.git;a=commit;h=fca5670ebcc91bd34bdadc03bc98c18cec159f79
>>>
>>>
>>> Someone who cares should figure out the necessary changes to make this
>>> patch compile and run correctly and send them upstream.
>>>
>>> The interested folks appear to be subscribed at
>>> https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/330259
>>>
>>> rtg
>> Not that I care too much, but this patch compiles and should have the
>> same effects as the old one. I would leave it to Andy next week to do
>> the upstreaming.
>>
>> Stefan
>>
> 
> OK, I'll buy it. I was originally concerned that there were semantic
> issues, but I went back and looked at the commit that changed
> atkbd_setup_fixup() to atkbd_setup_forced_release. It appears to be an
> extension of the original behavior.
> 
> applied.

Rather simplification I would say. The initial code looks like all the fixups 
where release key problems where every different set of keys required the 
nearly identical function. The newer code has one function that does that 
generically and requires only the keyset as special table.


-- 

When all other means of communication fail, try words!






More information about the kernel-team mailing list