[PATCH] e1000e: Unmap NV RAM when not in use.

Stefan Bader stefan.bader at canonical.com
Fri Sep 26 12:47:03 BST 2008


Tim Gardner wrote:
> This is what I'm thinking for the e1000e driver. Comments?
> 
> rtg
> 

Keep in mind: this is morning and not enough coffee yet...

I havn't compared against the whole source, but some error cases have replaced
"goto out" with direct returns. Doesn't that leave the nvram mapped?

Just nitpick: e1000_update_nvm_checksum_ich8lan could change the order of
out_release and out to save a goto.

Stefan

-- 

When all other means of communication fail, try words!





More information about the kernel-team mailing list