[PATCH] e1000e: Unmap NV RAM when not in use.

Colin Ian King colin.king at canonical.com
Fri Sep 26 08:35:14 UTC 2008


On Fri, 2008-09-26 at 10:41 +0300, Amit Kucheria wrote:
> On Fri, Sep 26, 2008 at 7:28 AM, Tim Gardner <tim.gardner at canonical.com> wrote:
> > This is what I'm thinking for the e1000e driver. Comments?
> >
> > rtg
> > --
> > Tim Gardner tim.gardner at canonical.com
> 
> So you map/unmap nvram on init/read/update/validate and still leave
> out write_nvm() ?
> 
> Why not just do the map/unmap around acquire_swflag and release_swflag?

If my understanding is correct, the strategy is only map/unmap when one
requires access to hw.flash_address, so it seems Amit's suggestion make
a lot of sense. In which case, shouldn't the ioremap() for
hw.flash_address be removed from netdev.c, around line ~5209? and
corresponding iounmap()s be also culled in netdev.c too?

Colin.





More information about the kernel-team mailing list