SRU - LP #276990 - iwlagn: downgrade BUG_ON in interrupt

Tim Gardner tcanonical at tpi.com
Wed Nov 5 18:50:21 UTC 2008


Ben Collins wrote:
> Tim Gardner wrote:
>> >From f09c6f52dc6b81f02599c8de3ed0ef5c74eadae1 Mon Sep 17 00:00:00 2001
>> From: Johannes Berg <johannes at sipsolutions.net>
>> Date: Tue, 23 Sep 2008 19:18:43 +0200
>> Subject: [PATCH] iwlagn: downgrade BUG_ON in interrupt
>>
>> LP: #276990
>>
>> This BUG_ON really shouldn't trigger, but if it does, as on my machine,
>> it leaves you wondering what happened because you won't see it. Let's
>> instead leak a bit of state and memory and at least make it possible to
>> report it to the kerneloops project to track it.
> 
> Temporary NACK, see reply to initial thread. I'm worried there may be 
> spew to the log.
> 

I think the theory is that instead of borking, just print a warning in
dmesg. At this point the adapter has stopped working, so there shouldn't
be any more messages. I believe Intel is still working on this problem.

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list