[PATCH] UBUNTU: export snd_hda_codec_read and snd_hda_codec_write

[Ben Collins]

On Thu, 2008-06-05 at 15:28 -0400, Torsten Spindler wrote:
> Signed-off-by: Torsten Spindler <torsten at canonical.com>
> 
> hda_codec.h is now available from lum-headers, snd_hda_codec_read
> and snd_codec_write is exported to allow LSI modem driver to compile.
> ---
>  debian/rules.d/2-binary-arch.mk              |    1 +
>  ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 4049f19..8d81acd 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -81,6 +81,7 @@ endif
>  	install -d $(hdrdir)/sound
>  	cp  $(builddir)/build-$*/sound/alsa-driver/include/config{,1}.h  $(hdrdir)/sound
>  	cp `find $(builddir)/build-$*/sound/alsa-kernel/include -type f` $(hdrdir)/sound
> +	cp $(builddir)/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.h $(hdrdir)/sound

NACK.

This part of the patch looks wrong. Shouldn't it be
$(builddir)/build-$*/sound/.. and not the "/ubuntu/" sub-directory you
have there?

Also, I'm a little reluctant to export functions, knowing that we are
doing so for a non-GPL driver. These are GPL functions, not exported by
the author and copyright holders. Exporting them ourselves, knowing that
we do so for non-GPL, closed source drivers, may be leaving us open to
some backlash, at the very least.

If I'm mistaken, and the LSI modem driver isn't closed source, then
let's just get the source in lum instead.

>  	# WiMAX headers
>  	install -d $(hdrdir)/include/linux $(hdrdir)/include/net
>  	cp `find $(builddir)/build-$*/wireless/wimax-i2400m/include/linux -type f` $(hdrdir)/include/linux
> diff --git a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> index 2fcace0..f7fbb14 100644
> --- a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> +++ b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> @@ -101,6 +101,7 @@ unsigned int snd_hda_codec_read(struct hda_codec *codec, hda_nid_t nid,
>  	snd_hda_power_down(codec);
>  	return res;
>  }
> +EXPORT(snd_hda_codec_read);
>  
>  /**
>   * snd_hda_codec_write - send a single command without waiting for response
> @@ -125,6 +126,7 @@ int snd_hda_codec_write(struct hda_codec *codec, hda_nid_t nid, int direct,
>  	snd_hda_power_down(codec);
>  	return err;
>  }
> +EXPORT(snd_hda_codec_write);
>  
>  /**
>   * snd_hda_sequence_write - sequence writes
> -- 
> 1.5.4.3
> 
> 
>