[PATCH] hid: wellspring device quirks

Tim Gardner tim.gardner at canonical.com
Tue Jul 15 20:56:48 UTC 2008

Henrik Rydberg wrote:
> On Tue, 2008-07-15 at 13:41 -0600, Tim Gardner wrote:
>> Henrik Rydberg wrote:
>>> From: Henrik Rydberg <rydberg at euromail.se>
>>> This patch adds the HID_QUIRK_IGNORE_MOUSE quirk for the Apple USB
>>> multitouch devices based on BCM5974, aka Wellspring. These devices
>>> will instead be picked up by the new bcm5974 driver.
>>> Signed-off-by: Henrik Rydberg <rydberg at euromail.se>
>>> --- 
> [...]
>> Rather then modifying the kernel quirks list, how about updating the
>> quirks list dynamically. It has the advantage of not causing regressions
>> for folks that do not have LBM installe.  For example, see
>> atp_update_quirks() in this patch. It could also work for the upstream
>> kernel version as well.
>> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy-lbm.git;a=commit;h=32f4209218f2b5481db8643504e9d66060fb9dae
> Excellent - you can tell I did not know about this possibility. :)
> The device constants are present twice, but I suppose that is fixable
> later on, if things are already committed. The same goes for the
> upstream version, once settled. I will have a look at the dynamic quirks
> then as well.
> Cheers,
> Henrik

I agree with regard to the duplication of the constants. Your driver has
not been pulled by Linus, so you may yet have time to get akpm to
replace the existing patch with something closer to what I have in LBM.

Tim Gardner tim.gardner at ubuntu.com

More information about the kernel-team mailing list