Jaunty config changes: Build in I2C

Tim Gardner tim.gardner at canonical.com
Fri Dec 26 14:17:39 UTC 2008


Andy Whitcroft wrote:
> On Mon, Dec 22, 2008 at 03:48:58PM -0700, Tim Gardner wrote:
>> From 16eb8b2f6f8bea7a9f532a72b3a6dbc04e663ee6 Mon Sep 17 00:00:00
>> 2001 From: Tim Gardner <tim.gardner at canonical.com> Date: Mon, 22
>> Dec 2008 13:39:33 -0700 Subject: [PATCH] UBUNTU: Build in I2C
>> 
>> Signed-off-by: Tim Gardner <tim.gardner at canonical.com> --- 
>> debian/config/amd64/config |    6 +++++- debian/config/i386/config
>> |    6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-)
>> 
>> diff --git a/debian/config/amd64/config
>> b/debian/config/amd64/config index 01478f6..2dd8ede 100644 ---
>> a/debian/config/amd64/config +++ b/debian/config/amd64/config @@
>> -240,6 +240,7 @@ CONFIG_B44_PCI_AUTOSELECT=y 
>> CONFIG_BACKLIGHT_CARILLO_RANCH=m CONFIG_BACKLIGHT_CLASS_DEVICE=y 
>> CONFIG_BACKLIGHT_CORGI=m +CONFIG_BACKLIGHT_DA903X=m 
>> CONFIG_BACKLIGHT_LCD_SUPPORT=y CONFIG_BACKLIGHT_MBP_NVIDIA=m 
>> CONFIG_BACKLIGHT_PROGEAR=m @@ -1123,7 +1124,7 @@ CONFIG_HYSDN=m 
>> CONFIG_HYSDN_CAPI=y # CONFIG_HZ_1000 is not set # CONFIG_HZ_300 is
>> not set -CONFIG_I2C=m +CONFIG_I2C=y CONFIG_I2C_ALGOBIT=m 
>> CONFIG_I2C_ALGOPCA=m CONFIG_I2C_ALGOPCF=m @@ -1589,6 +1590,7 @@
>> CONFIG_LCD_VGG2432A4=m CONFIG_LDM_PARTITION=y CONFIG_LEDS_CLASS=m #
>> CONFIG_LEDS_CLEVO_MAIL is not set +CONFIG_LEDS_DA903X=m 
>> CONFIG_LEDS_GPIO=m CONFIG_LEDS_HP_DISK=m CONFIG_LEDS_PCA9532=m @@
>> -2331,6 +2333,7 @@ CONFIG_PLIP=m CONFIG_PLIST=y CONFIG_PLX_HERMES=m
>>  CONFIG_PM=y +CONFIG_PMIC_DA903X=y CONFIG_PM_DEBUG=y 
>> CONFIG_PM_DISABLE_CONSOLE=y CONFIG_PM_SLEEP=y @@ -2406,6 +2409,7 @@
>> CONFIG_REED_SOLOMON=m CONFIG_REED_SOLOMON_DEC16=y 
>> CONFIG_REGULATOR=y CONFIG_REGULATOR_BQ24022=m 
>> +CONFIG_REGULATOR_DA903X=m # CONFIG_REGULATOR_DEBUG is not set #
>> CONFIG_REGULATOR_FIXED_VOLTAGE is not set 
>> CONFIG_REGULATOR_VIRTUAL_CONSUMER=m diff --git
>> a/debian/config/i386/config b/debian/config/i386/config index
>> 51820c2..fa4350a 100644 --- a/debian/config/i386/config +++
>> b/debian/config/i386/config @@ -260,6 +260,7 @@
>> CONFIG_B44_PCI_AUTOSELECT=y CONFIG_BACKLIGHT_CARILLO_RANCH=m 
>> CONFIG_BACKLIGHT_CLASS_DEVICE=y CONFIG_BACKLIGHT_CORGI=m 
>> +CONFIG_BACKLIGHT_DA903X=m CONFIG_BACKLIGHT_LCD_SUPPORT=y 
>> CONFIG_BACKLIGHT_MBP_NVIDIA=m CONFIG_BACKLIGHT_PROGEAR=m @@ -1197,7
>> +1198,7 @@ CONFIG_HYSDN=m CONFIG_HYSDN_CAPI=y # CONFIG_HZ_1000 is
>> not set # CONFIG_HZ_300 is not set -CONFIG_I2C=m +CONFIG_I2C=y 
>> CONFIG_I2C_ALGOBIT=m CONFIG_I2C_ALGOPCA=m CONFIG_I2C_ALGOPCF=m @@
>> -1672,6 +1673,7 @@ CONFIG_LCD_VGG2432A4=m CONFIG_LDM_PARTITION=y 
>> CONFIG_LEDS_CLASS=m # CONFIG_LEDS_CLEVO_MAIL is not set 
>> +CONFIG_LEDS_DA903X=m CONFIG_LEDS_GPIO=m CONFIG_LEDS_HP_DISK=m 
>> CONFIG_LEDS_NET48XX=m @@ -2461,6 +2463,7 @@ CONFIG_PLIP=m 
>> CONFIG_PLIST=y CONFIG_PLX_HERMES=m CONFIG_PM=y 
>> +CONFIG_PMIC_DA903X=y CONFIG_PM_DEBUG=y CONFIG_PM_DISABLE_CONSOLE=y
>>  CONFIG_PM_SLEEP=y @@ -2551,6 +2554,7 @@ CONFIG_REED_SOLOMON=m 
>> CONFIG_REED_SOLOMON_DEC16=y CONFIG_REGULATOR=y 
>> CONFIG_REGULATOR_BQ24022=m +CONFIG_REGULATOR_DA903X=m 
>> CONFIG_REGULATOR_DEBUG=y # CONFIG_REGULATOR_FIXED_VOLTAGE is not
>> set CONFIG_REGULATOR_VIRTUAL_CONSUMER=m
> 
> The sudden appearence of all the DA903X module settings is counter 
> intuitive.  Picking the LEDS one at random I cannot see any obvious 
> reason for it to have suddenly appeared here:
> 
> config LEDS_DA903X tristate "LED Support for DA9030/DA9034 PMIC" 
> depends on LEDS_CLASS && PMIC_DA903X help This option enables support
> for on-chip LED drivers found on Dialog Semiconductor DA9030/DA9034
> PMICs.
> 
> Perhaps our configs were out of date before hand?
> 
> -apw
> 

See drivers/mfd/Kconfig 'config PMIC_DA903X'. PMIC_DA903X is dependent
on 'I2C=y'. Enabling PMIC_DA903X does enable several other modules.

I agree that its not intuitive. I suspect that PMIC_DA903X being
dependent on I2C=y is a bug in the Kconfig. See upstream commit
8e2eaabfd9f7d375a1bb202e644ce2dcc0659592.

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list