Jaunty config changes: Reduce CONFIG_LEGACY_PTY_COUNT to 0

[Andy Whitcroft]

On Mon, Dec 22, 2008 at 05:28:09PM +0000, Scott James Remnant wrote:
> On Mon, 2008-12-22 at 17:16 +0000, Andy Whitcroft wrote:
> 
> > I am not convinced that if we set CONFIG_LEGACY_PTY_COUNT that the user
> > will be able to use these devices at all.  In the init function we check
> > if this value is <= 0 and if so we abort initialising the driver:
> > 
> > static int legacy_count = CONFIG_LEGACY_PTY_COUNT;
> > [...]
> > static void __init legacy_pty_init(void)
> > {
> >         if (legacy_count <= 0)
> >                 return;
> > [...]
> > 
> You snipped the all-important line right below the first one:
> 
> module_param(legacy_count, int, 0);
> 
> This is a parameter that has CONFIG_LEGACY_PTY_COUNT as its *default*,
> not hard-coded value.
> 
> You can boot with pty.legacy_count=... and that will change the value of
> legacy_count, so when the driver init()s, it will be > 0

My comment was in the context of the irc conversation (which isn't
obvious I know) where the discussion was that the user could simply
mknod some files.  You are correct that if they use the kernel command
line they can get it to init.  And if that is the recommended use mode
it makes sense to go to 0.

I assume we need to release note this change BTW.

> > What about leaving this at 256, but simply moving it to be a module (=m)
> > instead.  I would not expect it to autoload so people who needed these
> > things could modprobe it, or add it to /etc/modules, but otherwise we
> > arn't using it so why have it in the kernel?
> > 
> Err, this is the entire pty subsystem - we need that ;)

Heh, fair enough.  I had stupidly assumed there were two modules.

-apw