Jaunty config changes: Reduce CONFIG_LEGACY_PTY_COUNT to 0

Andy Whitcroft apw at canonical.com
Mon Dec 22 17:16:36 UTC 2008

On Mon, Dec 22, 2008 at 08:23:00AM -0700, Tim Gardner wrote:
> From 4e79291096b0d6adc9726607c8f6b7df736a877e Mon Sep 17 00:00:00 2001
> From: Tim Gardner <tim.gardner at canonical.com>
> Date: Mon, 22 Dec 2008 07:51:12 -0700
> Requested by Scott Remnant, "Absolutely nothing we know of uses these legacy
> ptys (xterm statically linked with libc4?!) - though if someone really wants
> them, leaving the top option as y lets them create them with a boot-time option."
> This will save a bunch of mknod()s, since each legacy pty has two device nodes.

I am not convinced that if we set CONFIG_LEGACY_PTY_COUNT that the user
will be able to use these devices at all.  In the init function we check
if this value is <= 0 and if so we abort initialising the driver:

static int legacy_count = CONFIG_LEGACY_PTY_COUNT;
static void __init legacy_pty_init(void)
        if (legacy_count <= 0)

What about leaving this at 256, but simply moving it to be a module (=m)
instead.  I would not expect it to autoload so people who needed these
things could modprobe it, or add it to /etc/modules, but otherwise we
arn't using it so why have it in the kernel?


More information about the kernel-team mailing list