[Hardy] SRU: enable USB serial support on sparc

[Stefan Bader]

Andy Whitcroft wrote:
> On Thu, Dec 04, 2008 at 06:03:40PM +0100, Stefan Bader wrote:
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/305188
>>
>> requested by fabbione.
>>
>> SRU justification
>>
>> Impact: Currently no USB serial modules are build for sparc. Those are 
>> required to get a console over USB. Impact is small since this enablement 
>> only activates modules for sparc.
>>
>> Fix: Change config options to build certain USB serial modules.
>>
>> Testcase: Use a serial console with a serial USB adapter on sparc.
>>
>> -- 
>>
>> When all other means of communication fail, try words!
>>
>>
> 
>> From 3cd513c36645cf64b893e26bdd15909381512a1b Mon Sep 17 00:00:00 2001
>> From: Fabio M. Di Nitto <fdinitto at redhat.com>
>> Date: Thu, 4 Dec 2008 15:58:23 +0100
>> Subject: [PATCH] UBUNTU: Enable USB serial support on sparc
>>
>> Bug: #305188
>>
>> Select USB_SERIAL_AIRPRIME, USB_SERIAL_GENERIC, USB_SERIAL_OPTION and
>> USB_SERIAL_PL2303 features from USB_SERIAL set as those are the only one
>> tested by me.
>>
>> Signed-off-by: Fabio M. Di Nitto <fdinitto at redhat.com>
>> Signed-off-by: Stefan Bader <stefan.bader at canonical.com>
>> ---
>>  debian/config/sparc/config |   44 +++++++++++++++++++++++++++++++++++++++++---
>>  1 files changed, 41 insertions(+), 3 deletions(-)
>>
>> diff --git a/debian/config/sparc/config b/debian/config/sparc/config
>> index f7c6978..c64c592 100644
>> --- a/debian/config/sparc/config
>> +++ b/debian/config/sparc/config
>> @@ -310,7 +310,6 @@ CONFIG_DEBUG_KERNEL=y
>>  # CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set
>>  # CONFIG_DEBUG_LOCK_ALLOC is not set
>>  # CONFIG_DEBUG_MUTEXES is not set
>> -CONFIG_DEBUG_RODATA=y
> 
> This ...
> 
>>  # CONFIG_DEBUG_PAGEALLOC is not set
>>  # CONFIG_DEBUG_RT_MUTEXES is not set
>>  # CONFIG_DEBUG_SG is not set
>> @@ -369,7 +368,7 @@ CONFIG_DRM_RADEON=m
>>  CONFIG_DRM_SAVAGE=m
>>  CONFIG_DRM_TDFX=m
>>  CONFIG_DRM_VIA=m
>> -CONFIG_DRM_VIA_CHROME9=n
>> +# CONFIG_DRM_VIA_CHROME9 is not set
> 
> and this seem to be unrelated to the description?
> 
>>  CONFIG_DS1682=m
>>  CONFIG_DUMMY=m
>>  CONFIG_DUMMY_CONSOLE=y
>> @@ -1915,7 +1914,46 @@ CONFIG_USB_R8A66597_HCD=m
>>  CONFIG_USB_RIO500=m
>>  CONFIG_USB_RTL8150=m
>>  # CONFIG_USB_SE401 is not set
>> -# CONFIG_USB_SERIAL is not set
>> +CONFIG_USB_SERIAL=m
>> +# CONFIG_USB_SERIAL_AIRCABLE is not set
>> +CONFIG_USB_SERIAL_AIRPRIME=m
>> +# CONFIG_USB_SERIAL_ARK3116 is not set
>> +# CONFIG_USB_SERIAL_BELKIN is not set
>> +# CONFIG_USB_SERIAL_CH341 is not set
>> +# CONFIG_USB_SERIAL_CP2101 is not set
>> +# CONFIG_USB_SERIAL_CYBERJACK is not set
>> +# CONFIG_USB_SERIAL_CYPRESS_M8 is not set
>> +# CONFIG_USB_SERIAL_DEBUG is not set
>> +# CONFIG_USB_SERIAL_DIGI_ACCELEPORT is not set
>> +# CONFIG_USB_SERIAL_EDGEPORT is not set
>> +# CONFIG_USB_SERIAL_EDGEPORT_TI is not set
>> +# CONFIG_USB_SERIAL_EMPEG is not set
>> +# CONFIG_USB_SERIAL_FTDI_SIO is not set
>> +# CONFIG_USB_SERIAL_FUNSOFT is not set
>> +# CONFIG_USB_SERIAL_GARMIN is not set
>> +CONFIG_USB_SERIAL_GENERIC=y
>> +# CONFIG_USB_SERIAL_HP4X is not set
>> +# CONFIG_USB_SERIAL_IPAQ is not set
>> +# CONFIG_USB_SERIAL_IPW is not set
>> +# CONFIG_USB_SERIAL_IR is not set
>> +# CONFIG_USB_SERIAL_KEYSPAN is not set
>> +# CONFIG_USB_SERIAL_KEYSPAN_PDA is not set
>> +# CONFIG_USB_SERIAL_KLSI is not set
>> +# CONFIG_USB_SERIAL_KOBIL_SCT is not set
>> +# CONFIG_USB_SERIAL_MCT_U232 is not set
>> +# CONFIG_USB_SERIAL_MOS7720 is not set
>> +# CONFIG_USB_SERIAL_MOS7840 is not set
>> +# CONFIG_USB_SERIAL_NAVMAN is not set
>> +# CONFIG_USB_SERIAL_OMNINET is not set
>> +CONFIG_USB_SERIAL_OPTION=m
>> +# CONFIG_USB_SERIAL_OTI6858 is not set
>> +CONFIG_USB_SERIAL_PL2303=m
>> +# CONFIG_USB_SERIAL_SAFE is not set
>> +# CONFIG_USB_SERIAL_SIERRAWIRELESS is not set
>> +# CONFIG_USB_SERIAL_TI is not set
>> +# CONFIG_USB_SERIAL_VISOR is not set
>> +# CONFIG_USB_SERIAL_WHITEHEAT is not set
>> +# CONFIG_USB_SERIAL_XIRCOM is not set
>>  CONFIG_USB_SISUSBVGA=m
>>  # CONFIG_USB_SISUSBVGA_CON is not set
>>  CONFIG_USB_SL811_HCD=m
> 
> Other than that it looks pretty safe.
> 
> -apw

In the end you are right. Those changes are not related. I would vote however 
to let them slip in this way. There is no functional change introduced by them.

Stefan
-- 

When all other means of communication fail, try words!