SRU request for LP#249296

[Ben Collins]

On Tue, 2008-08-05 at 15:52 -0400, Stefan Bader wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Ben Collins wrote:
> > On Mon, 2008-08-04 at 15:24 -0400, Stefan Bader wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> https://bugs.launchpad.net/cmpc/+bug/249296
> >>
> >> SRU justification:
> >>
> >> Impact: After suspend the classmate PC will not reboot with any of the present
> >> boot methods, however it will reboot using the ACPI method (although its ACPI
> >> flags clearly deny this).
> >>
> >> Fix: The fix backports the ability to use reboot=a on the commandline from
> >> upstream. It adds dmi exception tables to let the classmate use this method
> >> without checking the flags and sets this method as a default for it (also by
> >> dmi matching). So impact for other machines is not expected, since the default
> >> of using the keyboard controller remains.
> >>
> >> Testcase: Reboot after suspend/resume on the classmate will hang without this,
> >> otherwise succeed.
> > 
> > Can we split this up then? It will make things easier to push upstream
> > changes and merge existing patches.
> > 
> 
> Splitted into 3 parts:
> - - Backport ability to reset the machine using the RESET_REG of ACPI
>   (Hardy/Intrepid*)
>    *Applicable partially to Intrepid, the framework is there but acpi_reboot()
>     does nothing and falls back to keyboard method. Commit SHA points to the
>     upstream commit that added this
> - - SAUCE: Add the ability to whitelist systems to use ACPI reboot
>   (Hardy/Intrepid) taken from a proposal of the referenced bug report.
> - - SAUCE: Add reboot=a preselection quirk
>   (Hardy/Intrepid) This is optional and just selects the right method for
>   reboot, adds to the code already in place for Dell.

ACK on all three. Thanks for the breakdown.

> - --
> 
> When all other means of communication fail, try words!
> 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFImK9mP+TjRTJVqvQRAnXlAKDZ6PeygMoR1li9NuOiRv57YlrxAgCg/FEl
> k8ZmkWkAU8M0ixfGmpYaS3Y=
> =M/rL
> -----END PGP SIGNATURE-----