SRU reguest for lp#254783

Ben Collins ben.collins at canonical.com
Tue Aug 5 20:08:35 UTC 2008


On Tue, 2008-08-05 at 15:58 -0400, Stefan Bader wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Ben Collins wrote:
> > On Mon, 2008-08-04 at 18:13 -0400, Stefan Bader wrote:
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/254783
> > 
> > Note: the patch is mostly a cherry-pick but needed one function moved around.
> > 
> > SRU justification:
> > 
> > Impact: The USB-PERSIST feature (0458d5b4c9cc4ca0f62625d0144ddc4b4bc97a3c) lets
> > USB mounted filesystems remain intact (the USB device not removed) during power
> > loss. This is important for small machines that have their root fs on a USB
> > device. However this did not work in all cases.
> > 
> > Fix: A patch (5e6effaed6da94e727cd45f945ad2489af8570b3) that followed later
> > fixed the persist problem to work on all sleep states instead of supporting
> > only those where the hub lost power.
> > 
> > Testcase: Suspend fails on the classmate PC without this patch.
> > 
> >> Instead of moving the function, can we just get a forward declaration?
> >> Will make it easier to see how much is really changing in this diff.
> > 
> >> Thanks
> > 
> 
> Tried to keep close to upstream, which moved the function (but not with the
> same commit). But I changed that to a forward declaration.
> 
> Applicable: Hardy only

ACK on this version of the patch.

> - --
> 
> When all other means of communication fail, try words!
> 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFImLDnP+TjRTJVqvQRAuESAKCustLkKfJ27q/SlAJGW0TqPeh/uACg6dcB
> Eaqw/O/mH0M71kcRDuFiPC8=
> =9oOZ
> -----END PGP SIGNATURE-----





More information about the kernel-team mailing list