[PATCH 1/2] Implementation of prefetch core functionality (tracing and prefetching)

Krzysztof Lichota krzysiek at lichota.net
Tue Aug 14 15:30:18 UTC 2007

Ben Collins napisaƂ(a):
> @@ -115,7 +119,11 @@ generic_file_direct_IO(int rw, struct ki
>  void __remove_from_page_cache(struct page *page)
>  {
>  	struct address_space *mapping = page->mapping;
> -
> +	
> +	prefetch_page_release_hook(page);
> +#endif
> Likewise, the header should declare this as a nop macro, e.g.
> do{}while(0) when PREFETCH_CORE is not defined. Keeps the code clean.

OK. I did not come up with that idea.

> There's a lot of other formatting and style issues. Lots of places where
> you actually use typedefs for structs, when you really shouldn't be.
> Please read Documentation/CodingStyle and fix things up appropriately.

OK. I will fix the style.

Any problems with other things, apart from style?

	Krzysztof Lichota

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20070814/ad76664e/attachment.sig>

More information about the kernel-team mailing list