[PATCH 8/9] [UBUNTU:sound/isa/gus] Fix gus_pcm dereference before NULL

[crimsun at fungus.sh.nu]

Subject: [PATCH 8/9] [UBUNTU:sound/isa/gus] Fix gus_pcm dereference before NULL

UpstreamStatus: Applied, http://kernel.org/git/?p=linux/kernel/git/perex/alsa-current.git;a=commitdiff;h=d61975fc6b40dadd2cd61fc9535499c7d7b806de

This patch from Eugene Teo fixes Coverity bug #861 where the NULL check
of substream is unwarranted.

Signed-off-by: Daniel T Chen <crimsun at ubuntu.com>

---

 sound/isa/gus/gus_pcm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

53c2a30ceb2b7eddc98d386de10087b9e02db82c
diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c
index 1cc89fb..9eafbea 100644
--- a/sound/isa/gus/gus_pcm.c
+++ b/sound/isa/gus/gus_pcm.c
@@ -114,8 +114,6 @@ static void snd_gf1_pcm_trigger_up(snd_p
 	unsigned char pan;
 	unsigned int voice;
 
-	if (substream == NULL)
-		return;
 	spin_lock_irqsave(&pcmp->lock, flags);
 	if (pcmp->flags & SNDRV_GF1_PCM_PFLG_ACTIVE) {
 		spin_unlock_irqrestore(&pcmp->lock, flags);
-- 
1.1.3


-- 
Daniel T. Chen            crimsun at ubuntu.com
GPG key:   www.sh.nu/~crimsun/pubkey.gpg.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20060328/6bff9e59/attachment.sig>