[PATCH 1/9] [UBUNTU:sound/isa/cs423x] Fix silence in right channel of cs4236+ driver

crimsun at fungus.sh.nu crimsun at fungus.sh.nu
Tue Mar 28 08:16:22 UTC 2006


Subject: [PATCH 1/9] [UBUNTU:sound/isa/cs423x] Fix silence in right channel of cs4236+ driver

UpstreamStatus: Applied, http://kernel.org/git/?p=linux/kernel/git/perex/alsa-current.git;a=commitdiff;h=a5a6bbd9b2481dd556236ea866424590f5f987a4

A typo in sound/isa/cs423x/cs4236_lib.c::snd_cs4236_put_master_digital()
prevents the right channel from outputting audio in cs4236+. This patch
fixes the silence.

Signed-off-by: Daniel T Chen <crimsun at ubuntu.com>

---

 sound/isa/cs423x/cs4236_lib.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

05d1255d14e14d0a02d8d8e60fbd4a93c7012e97
diff --git a/sound/isa/cs423x/cs4236_lib.c b/sound/isa/cs423x/cs4236_lib.c
index 1adb88d..80af1db 100644
--- a/sound/isa/cs423x/cs4236_lib.c
+++ b/sound/isa/cs423x/cs4236_lib.c
@@ -644,7 +644,7 @@ static int snd_cs4236_put_master_digital
 	val2 = (chip->eimage[CS4236_REG(CS4236_RIGHT_MASTER)] & ~0x7f) | val2;
 	change = val1 != chip->eimage[CS4236_REG(CS4236_LEFT_MASTER)] || val2 != chip->eimage[CS4236_REG(CS4236_RIGHT_MASTER)];
 	snd_cs4236_ext_out(chip, CS4236_LEFT_MASTER, val1);
-	snd_cs4236_ext_out(chip, CS4236_RIGHT_MASTER, val1);
+	snd_cs4236_ext_out(chip, CS4236_RIGHT_MASTER, val2);
 	spin_unlock_irqrestore(&chip->reg_lock, flags);
 	return change;
 }
-- 
1.1.3


-- 
Daniel T. Chen            crimsun at ubuntu.com
GPG key:   www.sh.nu/~crimsun/pubkey.gpg.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20060328/c88bd316/attachment.pgp>


More information about the kernel-team mailing list