[Bug 145377] Re: Powertop reports huge number of wakeups and drains battery

fishor bug-track at fisher-privat.net
Wed Jul 16 19:03:21 UTC 2008

commit 635416ef393e8cec5a89fc6c1de710ee9596a51e
Author: Alan Cox <alan at lxorguk.ukuu.org.uk>
Date:   Mon Jun 16 14:35:15 2008 +0200

    pcmcia: irq probe can be done without risking an IRQ storm
    Nowdays you can ask for an IRQ to be allocated but not enabled, when
    was written this was not true and this feature is thus not used
    [linux at dominikbrodowski.net: add comment and ifdef to avoid
     breakage at least on alpha]
    Signed-off-by: Alan Cox <alan at redhat.com>
    Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
    Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>

diff --git a/drivers/pcmcia/pcmcia_resource.c
index c8f77b8..78af594 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -812,6 +812,15 @@ int pcmcia_request_irq(struct pcmcia_device *p_dev,
                type = IRQF_SHARED;
+       /* if the underlying IRQ infrastructure allows for it, only
+        * the IRQ, but do not enable it
+        */
+       if (!(req->Attributes & IRQ_HANDLE_PRESENT))
+               type |= IRQ_NOAUTOEN;
+#endif /* IRQ_NOAUTOEN */
        if (s->irq.AssignedIRQ != 0) {
                /* If the interrupt is already assigned, it must be the
same */
                irq = s->irq.AssignedIRQ;

Powertop reports huge number of wakeups and drains battery
You received this bug notification because you are a member of Kernel
Bugs, which is subscribed to Linux.

More information about the kernel-bugs mailing list