[Bug 12900] New: Regression issue with external-global-acpi_update.dpatch - detecting C2/C3 states for systems without CST

bugzilla-daemon at bugzilla.ubuntu.com bugzilla-daemon at bugzilla.ubuntu.com
Sat Jul 23 13:30:57 UTC 2005


Please do not reply to this email.  You can add comments at
http://bugzilla.ubuntu.com/show_bug.cgi?id=12900
Ubuntu | linux

           Summary: Regression issue with external-global-acpi_update.dpatch
                    - detecting C2/C3 states for systems without CST
           Product: Ubuntu
           Version: unspecified
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: linux
        AssignedTo: fabbione at ubuntu.com
        ReportedBy: Peter_Pregler at email.com
         QAContact: kernel-bugs at lists.ubuntu.com


The respective acpi-update has a regression issue with detecting C2/C3 states
for systems without CST. Either pull in an updated version from the ACPI-tree or
apply the patch below. With the current dpatch C2/C3 states stop working on some
laptops. Actually, pulling in patches and not even given the status or time of
the pull in the patch (see DP-lines) is a quite risky approach. Ubuntu-breezy
should not be a regression-repository for acpi-patches, IMHO.

===========================
From: Jindrich Makovicka
<makovick-/k6j/d2J2EitDQUhxP5w7+MCGPLT8p0O at public.gmane.org>

Re-enable C2/C3 states for systems without CST.  Fixes a regression after
the patch for C2/C3 support for multiprocessors
(http://bugme.osdl.org/show_bug.cgi?id=4401), which accidentally removed
the acpi_processor_power_verify() call.

Signed-off-by: Jindrich Makovicka
<makovick-/k6j/d2J2EitDQUhxP5w7+MCGPLT8p0O at public.gmane.org>
Cc: "Brown, Len" <len.brown-ral2JQCrhuEAvxtiuMwx3w at public.gmane.org>
Signed-off-by: Andrew Morton <akpm-3NddpPZAyC0 at public.gmane.org>
---

 drivers/acpi/processor_idle.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN
drivers/acpi/processor_idle.c~acpi-re-enable-c2-c3-cpu-states-for-systems-without
drivers/acpi/processor_idle.c
---
devel/drivers/acpi/processor_idle.c~acpi-re-enable-c2-c3-cpu-states-for-systems-without
2005-07-14 15:53:47.000000000 -0700
+++ devel-akpm/drivers/acpi/processor_idle.c	2005-07-14 15:53:47.000000000 -0700
@@ -881,7 +881,7 @@ static int acpi_processor_get_power_info
 	result = acpi_processor_get_power_info_cst(pr);
 	if ((result) || (acpi_processor_power_verify(pr) < 2)) {
 		result = acpi_processor_get_power_info_fadt(pr);
-		if (result)
+		if ((result) || acpi_processor_power_verify(pr) < 2)
 			result = acpi_processor_get_power_info_default_c1(pr);
 	}
 
_

-- 
Configure bugmail: http://bugzilla.ubuntu.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the kernel-bugs mailing list