<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div style="" class="markdown-here-wrapper"
data-md-url="Thunderbird">
<p style="margin: 1.2em 0px ! important;">Reviews from Tuesday,
March 24th</p>
<h3 style="margin: 1.3em 0px 1em; padding: 0px; font-weight:
bold;font-size: 1.3em;" id="nrpe-external-master">nrpe-external-master</h3>
<p style="margin: 1.2em 0px ! important;">Fixes a duplication
issue with rsync and increases the amulet test timeout. +1</p>
<p style="margin: 1.2em 0px ! important;"><a
href="https://code.launchpad.net/%7Epaulgear/charms/precise/nrpe-external-master/fix-duplicate-rsync-entries/+merge/250248">https://code.launchpad.net/~paulgear/charms/precise/nrpe-external-master/fix-duplicate-rsync-entries/+merge/250248</a></p>
<h3 style="margin: 1.3em 0px 1em; padding: 0px; font-weight:
bold;font-size: 1.3em;" id="kibana">kibana</h3>
<p style="margin: 1.2em 0px ! important;">Add apt-get update. +1<br>
<a
href="https://code.launchpad.net/%7Edannf/charms/trusty/kibana/lp1428865/+merge/252132">https://code.launchpad.net/~dannf/charms/trusty/kibana/lp1428865/+merge/252132</a></p>
<h3 style="margin: 1.3em 0px 1em; padding: 0px; font-weight:
bold;font-size: 1.3em;" id="jenkins">jenkins</h3>
<p style="margin: 1.2em 0px ! important;">Fixs a typo +1 in the
metadata description. +1</p>
<p style="margin: 1.2em 0px ! important;"><a
href="https://code.launchpad.net/%7Edannf/charms/trusty/jenkins/typo/+merge/253111">https://code.launchpad.net/~dannf/charms/trusty/jenkins/typo/+merge/253111</a></p>
<h3 style="margin: 1.3em 0px 1em; padding: 0px; font-weight:
bold;font-size: 1.3em;" id="ubuntu">ubuntu</h3>
<p style="margin: 1.2em 0px ! important;">Adds a config option to
create a subnet or use an existing network interface. The README
needs updating to document the new option.</p>
<p style="margin: 1.2em 0px ! important;"><a
href="https://code.launchpad.net/%7Ecbjchen/charms/trusty/ubuntu/lxc-network-config/+merge/250666">https://code.launchpad.net/~cbjchen/charms/trusty/ubuntu/lxc-network-config/+merge/250666</a></p>
<h3 style="margin: 1.3em 0px 1em; padding: 0px; font-weight:
bold;font-size: 1.3em;" id="apache2">apache2</h3>
<p style="margin: 1.2em 0px ! important;">This merge syncs vhost
templates from the trusty branch. There’s a lint error being
thrown to a duplicate test name. There are other test failures,
but they’re related to an open bug in trunk.</p>
<p style="margin: 1.2em 0px ! important;"><a
href="https://code.launchpad.net/%7Ebloodearnest/charms/precise/apache2/vhost-template-vars/+merge/251268">https://code.launchpad.net/~bloodearnest/charms/precise/apache2/vhost-template-vars/+merge/251268</a><br>
<a
href="https://bugs.launchpad.net/charms/+source/apache2/+bug/1401944">https://bugs.launchpad.net/charms/+source/apache2/+bug/1401944</a></p>
<h3 style="margin: 1.3em 0px 1em; padding: 0px; font-weight:
bold;font-size: 1.3em;" id="rabbitmq-server">rabbitmq-server</h3>
<p style="margin: 1.2em 0px ! important;">This merge updates
charmhelpers, adds a nagios config option and an nrpe service
check. There are issues in trunk with tests failing while
attempting to make an SSL connection unrelated to this merge.
I’ve submitted a bug against the test failures, and given my +1
to this merge.</p>
<p style="margin: 1.2em 0px ! important;"><a
href="https://code.launchpad.net/%7Ebrad-marshall/charms/trusty/rabbitmq-server/nagios-fixes-sync-charmhelpers/+merge/251551">https://code.launchpad.net/~brad-marshall/charms/trusty/rabbitmq-server/nagios-fixes-sync-charmhelpers/+merge/251551</a><br>
<a
href="https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1436014">https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1436014</a></p>
<h3 style="margin: 1.3em 0px 1em; padding: 0px; font-weight:
bold;font-size: 1.3em;" id="postgresql">postgresql</h3>
<p style="margin: 1.2em 0px ! important;">This is still a
work-in-progress review. There are intermittent failures related
to a bug in juju-core and juju-deployer that I’m tracking. </p>
<p style="margin: 1.2em 0px ! important;"><a
href="https://code.launchpad.net/%7Estub/charms/precise/postgresql/enable-integration-tests/+merge/238283">https://code.launchpad.net/~stub/charms/precise/postgresql/enable-integration-tests/+merge/238283</a><br>
<a href="https://bugs.launchpad.net/juju-deployer/+bug/1421315">https://bugs.launchpad.net/juju-deployer/+bug/1421315</a></p>
<div
title="MDH:UmV2aWV3cyBmcm9tIFR1ZXNkYXksIE1hcmNoIDI0dGg8YnI+PGJyPjxicj4jIyMgbnJwZS1leHRlcm5hbC1tYXN0ZXI8YnI+PGJyPkZpeGVzIGEgZHVwbGljYXRpb24gaXNzdWUgd2l0aCByc3luYyBh
bmQgaW5jcmVhc2VzIHRoZSBhbXVsZXQgdGVzdCB0aW1lb3V0LiArMTxicj48YnI+aHR0cHM6Ly9j
b2RlLmxhdW5jaHBhZC5uZXQvfnBhdWxnZWFyL2NoYXJtcy9wcmVjaXNlL25ycGUtZXh0ZXJuYWwt
bWFzdGVyL2ZpeC1kdXBsaWNhdGUtcnN5bmMtZW50cmllcy8rbWVyZ2UvMjUwMjQ4PGJyPjxicj4j
IyMga2liYW5hPGJyPjxicj5BZGQgYXB0LWdldCB1cGRhdGUuICsxPGJyPmh0dHBzOi8vY29kZS5s
YXVuY2hwYWQubmV0L35kYW5uZi9jaGFybXMvdHJ1c3R5L2tpYmFuYS9scDE0Mjg4NjUvK21lcmdl
LzI1MjEzMjxicj48YnI+IyMjIGplbmtpbnM8YnI+PGJyPkZpeHMgYSB0eXBvICsxIGluIHRoZSBt
ZXRhZGF0YSBkZXNjcmlwdGlvbi4gKzE8YnI+PGJyPmh0dHBzOi8vY29kZS5sYXVuY2hwYWQubmV0
L35kYW5uZi9jaGFybXMvdHJ1c3R5L2plbmtpbnMvdHlwby8rbWVyZ2UvMjUzMTExPGJyPjxicj4j
IyMgdWJ1bnR1PGJyPjxicj5BZGRzIGEgY29uZmlnIG9wdGlvbiB0byBjcmVhdGUgYSBzdWJuZXQg
b3IgdXNlIGFuIGV4aXN0aW5nIG5ldHdvcmsgaW50ZXJmYWNlLiBUaGUgUkVBRE1FIG5lZWRzIHVw
ZGF0aW5nIHRvIGRvY3VtZW50IHRoZSBuZXcgb3B0aW9uLjxicj48YnI+aHR0cHM6Ly9jb2RlLmxh
dW5jaHBhZC5uZXQvfmNiamNoZW4vY2hhcm1zL3RydXN0eS91YnVudHUvbHhjLW5ldHdvcmstY29u
ZmlnLyttZXJnZS8yNTA2NjY8YnI+PGJyPjxicj4jIyMgYXBhY2hlMjxicj48YnI+VGhpcyBtZXJn
ZSBzeW5jcyB2aG9zdCB0ZW1wbGF0ZXMgZnJvbSB0aGUgdHJ1c3R5IGJyYW5jaC4gVGhlcmUncyBh
IGxpbnQgZXJyb3IgYmVpbmcgdGhyb3duIHRvIGEgZHVwbGljYXRlIHRlc3QgbmFtZS4gVGhlcmUg
YXJlIG90aGVyIHRlc3QgZmFpbHVyZXMsIGJ1dCB0aGV5J3JlIHJlbGF0ZWQgdG8gYW4gb3BlbiBi
dWcgaW4gdHJ1bmsuPGJyPjxicj5odHRwczovL2NvZGUubGF1bmNocGFkLm5ldC9+Ymxvb2RlYXJu
ZXN0L2NoYXJtcy9wcmVjaXNlL2FwYWNoZTIvdmhvc3QtdGVtcGxhdGUtdmFycy8rbWVyZ2UvMjUx
MjY4PGJyPmh0dHBzOi8vYnVncy5sYXVuY2hwYWQubmV0L2NoYXJtcy8rc291cmNlL2FwYWNoZTIv
K2J1Zy8xNDAxOTQ0PGJyPjxicj48YnI+IyMjIHJhYmJpdG1xLXNlcnZlcjxicj48YnI+VGhpcyBt
ZXJnZSB1cGRhdGVzIGNoYXJtaGVscGVycywgYWRkcyBhIG5hZ2lvcyBjb25maWcgb3B0aW9uIGFu
ZCBhbiBucnBlIHNlcnZpY2UgY2hlY2suIFRoZXJlIGFyZSBpc3N1ZXMgaW4gdHJ1bmsgd2l0aCB0
ZXN0cyBmYWlsaW5nIHdoaWxlIGF0dGVtcHRpbmcgdG8gbWFrZSBhbiBTU0wgY29ubmVjdGlvbiB1
bnJlbGF0ZWQgdG8gdGhpcyBtZXJnZS4gSSd2ZSBzdWJtaXR0ZWQgYSBidWcgYWdhaW5zdCB0aGUg
dGVzdCBmYWlsdXJlcywgYW5kIGdpdmVuIG15ICsxIHRvIHRoaXMgbWVyZ2UuPGJyPjxicj5odHRw
czovL2NvZGUubGF1bmNocGFkLm5ldC9+YnJhZC1tYXJzaGFsbC9jaGFybXMvdHJ1c3R5L3JhYmJp
dG1xLXNlcnZlci9uYWdpb3MtZml4ZXMtc3luYy1jaGFybWhlbHBlcnMvK21lcmdlLzI1MTU1MTxi
cj5odHRwczovL2J1Z3MubGF1bmNocGFkLm5ldC9jaGFybXMvK3NvdXJjZS9yYWJiaXRtcS1zZXJ2
ZXIvK2J1Zy8xNDM2MDE0PGJyPjxicj4jIyMgcG9zdGdyZXNxbDxicj48YnI+VGhpcyBpcyBzdGls
bCBhIHdvcmstaW4tcHJvZ3Jlc3MgcmV2aWV3LiBUaGVyZSBhcmUgaW50ZXJtaXR0ZW50IGZhaWx1
cmVzIHJlbGF0ZWQgdG8gYSBidWcgaW4ganVqdS1jb3JlIGFuZCBqdWp1LWRlcGxveWVyIHRoYXQg
SSdtIHRyYWNraW5nLiA8YnI+PGJyPmh0dHBzOi8vY29kZS5sYXVuY2hwYWQubmV0L35zdHViL2No
YXJtcy9wcmVjaXNlL3Bvc3RncmVzcWwvZW5hYmxlLWludGVncmF0aW9uLXRlc3RzLyttZXJnZS8y
MzgyODM8YnI+aHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQvanVqdS1kZXBsb3llci8rYnVnLzE0
MjEzMTU8YnI+"
style="height:0;width:0;max-height:0;max-width:0;overflow:hidden;font-size:0em;padding:0;margin:0;"></div>
</div>
</body>
</html>