problem when building a charm for giraph

[Konstantinos Tsakalozos]

Hi Panagiotis,

Thank you for the time and effort you put into this charm.

We definitely need to look at the configuration properties you are
suggesting and we should also consider the addition of an interface for
injecting jars into Hadoop classpath.

At this point you have two options for having someone officially review
your charm:
a) You can request your charm to be promulgated, and/or
b) push your code upstream to the Apache Bigtop repo.
I would suggest you do both; it should not be much work.

Promulgating your charm means that the charm you have will be reviewed
by our charmers and if accepted will be recommended to the Juju store
visitors. The recomended revision will not be under your namespace
anymore (will be available as cs:xenial/giraph). To request a review
simply login here [1] with your lp credentials and click request review.

To push your code upstream to the Apache Bigtop project is also
pretty easy. I have created a ticket to add a Giraph charm [2]. The task
for you is to make a pull request with a title that matches exactly
the title of the Jira ticket prefixed by the BIGTOP-XXXX ticket number
i.e. "BIGTOP-2660: Add Giraph Charm". This will link your PR to the ticket.

Thank you,
Konstantinos

[1] https://review.jujucharms.com/reviews
[2] https://issues.apache.org/jira/browse/BIGTOP-2660


On Thu, Jan 5, 2017 at 5:04 PM, Panagiotis Liakos <p.liakos at di.uoa.gr>
wrote:

> Thanks a lot for the answers and the help with the charm set command.
> I believe you forgot to include links ([1], [2]), can you please
> re-send them?
>
> Thanks,
> Panagiotis
>
> 2017-01-05 15:55 GMT+02:00 Rick Harding <rick.harding at canonical.com>:
> > On Thu, Jan 5, 2017 at 8:17 AM Panagiotis Liakos <p.liakos at di.uoa.gr>
> wrote:
> >>
> >>
> >> Moreover, I have just released the latest version of my charm [2].
> >
> >
> > Congrats!
> >
> >>
> >> 1) Should I follow some procedure to find someone to review the charm?
> >
> >
> > Definitely, you can submit it to the review queue [1] and there's a
> document
> > that goes through some things to look out for going through the process
> [2].
> >
> >>
> >> 2) When I release my charm I get the following warning: bugs-url is
> >> not set.  See set command. Am I supposed to set such a bugs-url? Can I
> >> use https://github.com/panagiotisl/bigtop/issues ?
> >
> >
> > Exactly, where ever you want to track the bugs for the charm is up to
> you.
> > Use the charm command to set the bugs-url
> >
> > charm set cs:~panagiotisl/giraph bugs-url
> > https://github.com/panagiotisl/bigtop/issues
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20170106/54518297/attachment.html>