[Review Queue] IBM Platform RTM, LSF, Symphony, and Websphere Base

Kevin Monroe kevin.monroe at canonical.com
Fri Oct 21 14:29:19 UTC 2016


Hi folks,

Cory, Kostas, Pete, and myself had a look at the following this week:


   -

   IBM Platform RTM
   -

      https://bugs.launchpad.net/charms/+bug/1510216
      -

      Minor issues with config (offered suggestions) and readme
      instructions (fixed)
      -

      Amulet test needs work
      -

      Charm store policy violations.  As a reminder, recommended charms
      need to abide by the policy outlined here:
      -

         https://jujucharms.com/docs/stable/authors-charm-policy
         -

      -1 for now.
      -

   IBM Symphony Master
   -

      https://review.jujucharms.com/reviews/15
      -

      Finished a read-through of code, and checked off most of the boxes in
      our new review queue.
      -

      Rebuilt the charm locally and re-ran the tests. Am still seeing
      linter errors (though there are fewer, now that the storage
layer has been
      rebuilt).
      -

   IBM Platform LSF Master
   -

      https://review.jujucharms.com/reviews/17
      -

      Did a quick review of metadata, and set the section to green
      -

      Noticed some items in during code review that should be addressed;
      commented at https://bugs.launchpad.net/charms/+bug/1578271
      -

   IBM Platform LSF Server
   -

      https://review.jujucharms.com/reviews/18
      -

      Did a quick review of metadata, and set the section to green
      -

      Noticed some items during code review that should be addressed;
      commented at https://bugs.launchpad.net/charms/+bug/1578273
      -

   IBM Platform LSF Storage
   -

      https://bugs.launchpad.net/charms/+bug/1462212
      -

      Noticed some issues with status messages, required deployment names
      for related applications, and the use of “exit” in bash reactive handlers


   -

   IBM Websphere Base
   -

      https://bugs.launchpad.net/charms/+bug/1446966
      -

      We went though the build process and the instructions through the
      readme. Here are some issues we found and may need the authors attention:
      -

         Unregistered interfaces
         -

         Code style errors
         -

         Minor README fixes needed
         -

         Tests using charms from private namespace


Any questions or comments?  Please find us in Freenode #juju.  Thanks!
-Kevin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20161021/aa49325b/attachment.html>


More information about the Juju mailing list