[Review Queue] Abot, ubuntu-repo-cache, IBM, mongodb, haproxy, wordpress, squid

[Konstantinos Tsakalozos]

Hi all,


Here is the work the BigData team was doing on the review queue in the past
weeks:


July 14, 2016:  Cory/Kevin/Kostas/Pete

   -

   squid (centos)
   -


      https://code.launchpad.net/~dbuliga/charms/trusty/squid-reverseproxy/centos/+merge/287481
      -

      This merge request would bring squid to centos
      -

      There are tests that are failing so cannot move forward with this
      charm at this moment.
      -

   wordpress
   -


      https://code.launchpad.net/~jamesbeedy/charms/trusty/wordpress/apache2_trusty_fix/+merge/297720
      -

      Approved. Tests pass, and code looks good.
      -

      There might be a separate issue with the tests, though, unrelated to
      the PR. Filed a bug report. (
      https://bugs.launchpad.net/charms/+source/wordpress/+bug/1603153)
      -

   Ibm-db2
   -


      https://code.launchpad.net/~ibmcharmers/charms/trusty/ibm-db2/trunk/+merge/294153
      -

      Reviewed a couple recent fixes and readme updates
      -

      +1, published to https://jujucharms.com/ibm-db2/
      -

   haproxy (xenial)
   -


      https://code.launchpad.net/~jamesj/charms/trusty/haproxy/xenial-support/+merge/299196
      -

      Suggested changes were included and tests all pass
      -

      Still doesn’t work on Precise, which will run up against the issue of
      removing the Precise version from the store when the multi-series version
      is pushed


July 7, 2016: Cory/Kevin/Kostas/Pete/Andrew

   -

   haproxy (xenial)
   -


      https://code.launchpad.net/~jamesj/charms/trusty/haproxy/xenial-support/+merge/299196
      -

      Unit test failures due to new apt-install, missing deploy test for
      Xenial, deploy test failed on Xenial
      -

      Provided a branch with suggested tests and fixes
      -

      Suggested adding series to metadata and requested pushing to charm
      store per new promulgation policy
      -

   mongodb
   -


      https://code.launchpad.net/~billy-olsen/charms/trusty/mongodb/lp1513094/+merge/294565
      -

      Failed due to 2 amulet test issues which appear to be naming related
      -

   Ibm-db2
   -


      https://code.launchpad.net/~ibmcharmers/charms/trusty/ibm-db2/trunk/+merge/294153
      -

      We made some cosmetic and best-practice updates (things like bash
      string equality with == vs integer equality with -eq).
      -

      We noticed users were being created with default passwords, which
      violates charm store policy.  We made some fixes for this and asked the
      author to review our changes.
      -

   IBM PlatformMaster Interface
   -

      https://bugs.launchpad.net/charms/+bug/1578173
      -

      Interface for PlatformMaster which can be used by IBM Platform
      Products like Platform LSF and Platform Symphony
      -

      The interface looked good. We spotted only two minor issues: missing
      license and maintainer.
      -

   IBM NFSStorage interface
   -

      https://bugs.launchpad.net/charms/+bug/1578166
      -

      Interface for NFSStorage which can be used by IBM Platform Products
      like Platform LSF and Platform Symphony
      -

      The interface looked fine. We spotted only a few minor issues:
      missing license and maintainer, minor fixes needed on the README



June 30, 2016: Cory/Kevin/Kostas/Pete

   -

   Abot
   -

      https://bugs.launchpad.net/charms/+bug/1582176
      -

      This is the second review round of the Test Automation Framework.
      -

      We have spotted some more points that need improvement
      -

      We will also set up a call with the charm author to go over mainly
      the charm testing strategy.
      -

   ubuntu-repository-cache
   -


      https://code.launchpad.net/~cjwatson/charms/trusty/ubuntu-repository-cache/signed-is-metadata/+merge/295823
      -

      Currently, the linter tests, and one of the integration tests is
      failing. Left comments, along with a traceback, and changed the status to
      “Needs Fixing”



Thank you,
Konstantinos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160715/e4b81a39/attachment.html>