[Review Queue]

[Adam Israel]

Jenkins

While sprinting, I did an out of band review of a merge against the jenkins charm, which allows for executor customization, updates the jenkin plugins url, and allows the installation of remote .debs

The change raises a couple of minor points, neither of which were blockers in this case. I’ve merged this proposal.

The first is proxy access; this may fail in some restricted environments where http_proxy won’t work because units are communicating internally over http (i.e., nova). This issue will be resolved once this issue is landed: https://bugs.launchpad.net/juju-core/+bug/1488139 <https://bugs.launchpad.net/juju-core/+bug/1488139>.

The second issue is remote resources (debs, tarballs, etc) that don’t have a checksum available. The preference is to always cryptographically verify but in some cases this isn’t provided by the vendor.

https://code.launchpad.net/~lutostag/charms/trusty/jenkins/jenkins+executor+remote-deb+plugins-move/+merge/280974 <https://code.launchpad.net/~lutostag/charms/trusty/jenkins/jenkins+executor+remote-deb+plugins-move/+merge/280974>

--
Adam Israel - Software Engineer
Canonical Ltd.
http://juju.ubuntu.com/ - Automate your Cloud Infrastructure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160130/fc2ff340/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1345 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160130/fc2ff340/attachment.bin>