[Review Queue] memcached

[Adam Israel]

https://code.launchpad.net/~freyes/charms/trusty/memcached/lp1525026/+merge/281254 <https://code.launchpad.net/~freyes/charms/trusty/memcached/lp1525026/+merge/281254>

I reviewed a fix to allow the memcached charm’s tests to work (due to firewall issues). I reran tests on LXC and AWS and they failed, behavior I also manually confirmed.

I patched the tests to work on LXC:
https://code.launchpad.net/~aisrael/charms/trusty/memcached/charm-review-fixes <https://code.launchpad.net/~aisrael/charms/trusty/memcached/charm-review-fixes>

There is still a failure on Amazon, related to memcached running on the private IP and it being compared to the unit’s public address. 


--
Adam Israel - Software Engineer
Canonical Ltd.
http://juju.ubuntu.com/ - Automate your Cloud Infrastructure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160128/830f6ef4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1345 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160128/830f6ef4/attachment.bin>