[Review Queue] ibm-http, gluster, docker, ntpmaster, bip, mongodb, lsf, ibm spectrum symphony

[Pete Vander Giessen]

Hi All,


This week, Kevin, Kostas, Cory and I reviewed the following:



   -

   ibm-http
   -

      https://bugs.launchpad.net/charms/+bug/1612535
      -
   -

   gluster
   -

      https://bugs.launchpad.net/charms/+bug/1469213
      -

      Promulgated!
      -

   Docker
   -


      https://code.launchpad.net/~jamesbeedy/charms/trusty/docker/fix_apt_dep/+merge/300544
      -

      Couldn’t tell if this was still required as the MP fixes a non
      layered charm that has been superseded by a layered one that doesn’t have
      the problem.
      -

      Requested more info if this MP was still valid.
      -

   Ntpmaster
   -


      https://code.launchpad.net/~paulgear/charms/trusty/ntpmaster/add-query-hosts-option/+merge/301602
      -

      Already +1’d, but needs a ~landscape-charmer to push to their
      namespace.
      -

   BIP -- Client side SSL and charmhelpers cleanup
   -

      Followed up with charm maintainer -- charm needs to be merged into
      their namespace so that they can effectively function as a maintainer.
      -

   mongodb (fix backup)
   -


      https://code.launchpad.net/~evarlast/charms/trusty/mongodb/fix-backup/+merge/300671
      -

      Suggested improvement using shutil.rmtree()
      -

      I also think there is a pending refactor to this charm that might
      render this change moot; asked for direction from the maintainers.
      -

      Noted that this needs to move out of the ~charmers namespace.
      -

   LSF (Platform, Master and Server)
   -

      Manually built and tested all three charms.
      -

      They all work great, and have license files, icons and other
      requirements.
      -

      Gave the code a +1
      -

   IBM Spectrum Symphony Storage
   -

      https://bugs.launchpad.net/charms/+bug/1580017
      -

      This new charm deploys “IBM Spectrum Symphony Storage” and along with
      “IBM Spectrum Symphony Master” and “IBM Spectrum Symphony Node”
it forms a
      “Symphony Cluster”
      - We went through the code and tests and spotted a few points that
      need the author's attention. Namely misplacement of tests and
style errors
      and charm build issues.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160826/a8dcf680/attachment.html>