[Review Queue] kibana, ibm java sdk, jenkins-bundle

[Andrew Mcleod]

Your friendly Big Data team managed to get some quality review queue time
yesterday. Below are the results!


*kibana*

https://code.launchpad.net/~chris.macnaughton/charms/trusty/kibana/version_bump/+merge/274029

This review was for a version bump from 3 to 4 - The charm itself looks
good, the GUI is accessible after deployment, etc. However, two tests were
failing with connectivity issues - these seem to be relatively trivial
failures so I don't think this one is far off approval.


*IBM Java SDK*

https://bugs.launchpad.net/charms/+bug/1477067

This charm is interesting as it is the second from an ISV that offers an
alternative to our default openjdk/jre environment.  Azul Systems had Zulu8
promulgated a few weeks ago -- their charm is a subordinate designed to be
installed on an existing service unit (e.g tomcat).  This charm, by
contrast, is a primary service that installs a JDK, which would be useful
to develop/test java apps with the IBM JRE on different architectures.
We’re planning to sync with both Azul and IBM next week to discuss the
design of a common jre/jdk interface that all java-based services might
leverage.

In this iteration, the author addressed issues raised from a previous
review, and the charm installed with nice status messages along the way.

We found additional areas for improvement and created a merge proposal to
address them -- things like verifying the sha1sum of the installer, failing
fast on unsupported architectures, and additional status when the charm is
blocked for configuration.


*jenkins-bundle*

https://code.launchpad.net/~matsubara/charms/trusty/jenkins/jenkins-bundle/+merge/270415

This one also looks good, but there were a few minor items that need to be
addressed, such as some lint errors that were introduced, and some
questions / comments on the handling of the extension relation.


Have a great weekend!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151023/4664dadc/attachment.html>