[Review Queue] gpfs, xCAT, ubuntu-repository-cache, charm-tools

[Adam Israel]

        gpfs <https://bugs.launchpad.net/bugs/1479963>

The instructions provided in the README don’t match with the binary
provided to us for testing, and the documentation is too vague about
what needs to be done in order to provide the binary to the charm during
installation. I’ve recommended an update to the README and/or the binary.

Currently, the user is asked to install and configure apache to host a
private ubuntu repository on machine 0, to be used by the charm. Binary
distribution is an issue still being discussed. I’m satisfied with this
as an interim step, so long as the instructions to do so are clear and
concise.

I’ve opened a wishlist <https://bugs.launchpad.net/bugs/1479963> bug
against ubuntu-repository-cache, which I think could be modified with
the upcoming composer tools in charm-helpers, so that it could also be
used to host private repositories. This would greatly simplify the
process for charms that require proprietary binaries.


        xCAT <https://bugs.launchpad.net/charms/+bug/1441622>

There are several policy issues, most notably idempotent and a lack of
unit tests, that still need to be resolved. I’ve offered some examples
of how a charm requiring specific configuration values set in order to
install may work idempotently. Other minor issues include removing
unused hook-related files and a typo in the metadata.


        ubuntu-repository-cache
        <https://code.launchpad.net/%7Edaniel-thewatkins/charms/trusty/ubuntu-repository-cache/update_charm-helpers/+merge/265645>:

Fixes critical bug preventing the charm from being deployed. +1, merged.


        charm-tools w/composer
        <https://code.launchpad.net/%7Ebcsaller/charm-tools/composer/+merge/266281>

A very brief look at the new composer functionality coming to
charm-tools (and one I’m excited about, especially how it could solve
the use case provided by the /gpfs/ charm. There needs to be some docs
provided for charm authors so they can decide if composer is right for
them and, if so, how to implement it.

​

-- 
Adam Israel - Software Engineer
Canonical Ltd.
http://juju.ubuntu.com/ - Automate your Cloud Infrastructure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150730/b7bff949/attachment.html>