[Review Queue] wildfly-ha-master and wildfly-ha-slave

Cory Johns cory.johns at canonical.com
Wed Jan 7 17:58:08 UTC 2015


I reviewed this pair of charms and game them my +1 with the caveat
that a couple of small test fixes be made during promotion:

* The test (in wildfly-ha-master) needs to point to the charm store, not local:
* The test needs to be set to executable
* The test needs to be copied to wildfly-ha-slave

This makes the most sense to do during promotion, since the tests
won't pass until the charms are in the store (chicken-and-egg problem)
unless explicitly referring to local: (which won't work with the
automated test runner).


https://bugs.launchpad.net/charms/+bug/1399228
https://bugs.launchpad.net/charms/+bug/1399239



More information about the Juju mailing list