[Review Queue] PyBossa, and refactoring pgbouncer to use charmhelpers

[Cory Johns]

Today I reviewed two submissions from the review queue.

First, Marvin Reimer submitted a charm for the open-source
crowd-funding platform PyBossa.  Overall, the charm looks good, but I
had a few small improvements that I suggested, such as replacing
boilerplate config.yaml items with an empty mapping (options: {}).

I also pointed him to Chuck's blog post regarding personal namespaces
in the charm store
(http://blog.dasroot.net/the-power-of-community-charming/), since it
had not really been clear to me before that, and I wanted to make sure
Marvin understood that my suggestions for improvement should not hold
him back from promoting the charm as a way of managing PyBossa.

Second, I reviewed Stuart Bishop's refactor of the pgbouncer charm to
use charmhelpers.  He also added an amulet test, which was very
helpful in reviewing the refactor, but which unfortunately runs afoul
of this bug / feature request in core:
https://bugs.launchpad.net/juju-core/+bug/1200267

As Stuart noted in the test, that bug means that the test is dependent
on timing and it was failing for me until I increased the timeout, at
which point it passed without issue.  Being able to tell when a
service has hooks pending or executing is something that I've
struggled with on my own, as well, so I look forward to something
being available to address that, whether it be a simple indicator in
status, a plugin that can detect the state from the bootstrap node, or
proper extended status reporting from the charms.


Thanks,
Cory Johns