Reviewers, recheck that ~charmers are assigned a MP after the first pass

Jorge O. Castro jorge at ubuntu.com
Wed Jun 19 14:34:37 UTC 2013


Hi reviewers,

I thought that we were missing some merge proposals from the review queue.

https://bugs.launchpad.net/charmworld/+bug/1191823

In this case the review was assigned to Mark Mims instead of getting
back in the queue. We can solve this by reminding people submitting
that they need to explicitly resubmit the branch for review again.

So when you do your first review in the first pass, similarly to how
we do for new charms, reviewers should say something to the effect of
"When you're ready for another round please click the resubmit
button".

I'll put this in the review workflow in new-docs.

--
Jorge Castro
Canonical Ltd.
http://juju.ubuntu.com



More information about the Juju mailing list