A few issues

[Gustavo Niemeyer]

On Wed, Apr 10, 2013 at 5:59 PM, William Reade
<william.reade at canonical.com> wrote:
> On Wed, 2013-04-10 at 15:04 -0300, Gustavo Niemeyer wrote:
>> 1) Agent version shows "pending", when in fact the agent is running
>> install hooks as confirmed by logging into the machine and running ps.
>
> I believe the agent-state always stayed "pending" until the install hook
> either succeeded or failed; a quick look at the python seems to confirm
> this supposition. More sophistication here would be kinda cool, but out
> of scope for the moment.

I believe this is incorrect. Python has the "installed" status as
well, and I believe it covers that case. "pending" means that the
agent data is missing entirely, which isn't the situation described.

>> 2) There are two different agent versions in use, although this
>> environment was bootstrapped with --upload-tools from tip.
>
> Is it possible that you did --upload-tools from quantal and didn't
> --fake-series precise? There are some surprising aspects to cros-bucket

Yes, I didn't even know --fake-series existed. How does that work? Can
we make it easier for people just trying things out to not have to
read a lot of theory before it will work?

>> 3) Machine ids are still strings, incompatible with Python. Note that
>> this is the case in multiple places in the output, not just under
>> machines:.
>
> This is somewhat harder to address; my initial grasp on "this is
> definitely wrong" has weakened. There are several reasons it's
> convenient to externally identify machines by string rather than int,
> but there's one that seems to me to be overwhelming: and that reason is
> JSON.

It's not clear to me how that's relevant. JSON already formatted
machine ids as strings, both in Python and in the Go version we
implemented. This issue is only relevant in YAML, and it was broken
after the internal change in machine ids.

(...)
> I am aware that this is not a solution that will please you, and this

As you know I was indeed displeased with the fact that integers are
being represented as strings, but what I'm bringing up here is
unrelated to that. In this case I'm simply concerned that this is a
gratuitous incompatibility with existing logic that was broken mid-way
through the life of the Go port for no apparent reason. As usual, I'll
trust your judgement on the past path.


gustavo @ http://niemeyer.net