The push-for-review workflow

Michael Nelson absoludity at gmail.com
Thu Sep 1 06:49:19 UTC 2011


On Thu, Sep 1, 2011 at 5:58 AM, Gustavo Niemeyer
<gustavo.niemeyer at canonical.com> wrote:
> Hey folks!
>
> I was just wondering today.. how long do we take every time we have to
> go over the full procedure of getting a review.. push branch, create
> bug, change status, milestone, assignee, link branch, go to branch,

Out of interest, why are you creating a bug when submitting every
branch, rather than creating a branch to address a bug. If it's
feature work, is the bug just for recording the commit for QA? I have
done that when planning new features - creating bugs to split the work
up and then implementing it, but it seems (at least to me) that
something is wrong if we're creating a bug for every branch that we
push?

That said, the script looks *very* useful, I'll be looking forward to
using/modifying it too!

-Michael

FWIW: I use the --fixes lp:123455 option for bzr commit to
automatically link my branch.


> propose for merge, etc?
>
> What about.. 20 seconds!
>
> [niemeyer at gopher ../mine/some-test]% push-review
> 2011/09/01 00:44:41 Looking up branch information...
> 2011/09/01 00:44:42 Found branch: lp:~niemeyer/ensemble/some-test
> 2011/09/01 00:44:42 Logging into Launchpad...
> 2011/09/01 00:44:42 Editing summary and description for change...
> 2011/09/01 00:44:47 Got summary and description for change:
> -----
> push-review must be tested again
>
> That's just a test for push-review. Please ignore.
> -----
> 2011/09/01 00:44:47 Pushing branch to lp:~niemeyer/ensemble/some-test...
> 2011/09/01 00:44:47 Loading data for user "niemeyer"...
> 2011/09/01 00:44:47 Loading data for project "ensemble"...
> 2011/09/01 00:44:49 Loaded data for user "niemeyer".
> 2011/09/01 00:44:50 Loaded data for project "ensemble".
> 2011/09/01 00:44:50 Loading active milestones for project "ensemble"...
> 2011/09/01 00:44:50 Active milestone for project "ensemble" is "eureka".
> 2011/09/01 00:45:02 Branch pushed successfully.
> 2011/09/01 00:45:02 Creating bug...
> 2011/09/01 00:45:02 Loading data for branch lp:~niemeyer/ensemble/some-test...
> 2011/09/01 00:45:02 Loaded data for branch lp:~niemeyer/ensemble/some-test.
> 2011/09/01 00:45:02 Loading focus series for project "ensemble"...
> 2011/09/01 00:45:03 Focus series for project "ensemble" is "trunk".
> 2011/09/01 00:45:03 Loading target branch for series "trunk"...
> 2011/09/01 00:45:03 Created bug: https://bugs.launchpad.net/bugs/838568
> 2011/09/01 00:45:03 Loading bug task...
> 2011/09/01 00:45:03 Linking branch to bug...
> 2011/09/01 00:45:03 Creating merge proposal:
> lp:~niemeyer/ensemble/some-test => lp:ensemble
> 2011/09/01 00:45:04 Updating bug task status, milestone, and assignee...
> 2011/09/01 00:45:05 Merge proposal successfully created:
> https://code.launchpad.net/~niemeyer/ensemble/some-test/+merge/73623
> 2011/09/01 00:45:05 Bug task updated.
> 2011/09/01 00:45:06 Branch linked to bug.
> 2011/09/01 00:45:06 That's all folks.
>
> That's really it.. no command line options so far either.  I'll add
> support for pre-req branches though, and will publish the tool to some
> consumable location.
>
> As a side effect of this, the lpad library is _significantly_ improved:
>
>    http://goneat.org/pkg/lp/lpad
>
> These improvements will be useful for the store work as well.
>
> --
> Gustavo Niemeyer
> http://niemeyer.net
> http://niemeyer.net/plus
> http://niemeyer.net/twitter
> http://niemeyer.net/blog
>
> -- I never filed a patent.
>
> --
> Ensemble mailing list
> Ensemble at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ensemble
>



-- 
-
Michael Nelson
http://liveandletlearn.net
http://micknelson.wordpress.com/




More information about the Ensemble mailing list