<div dir="ltr">(or, at least, it's something like that -- the general point is that you shouldn't throw away values you don't know you don't need)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 11, 2016 at 2:14 PM, William Reade <span dir="ltr"><<a href="mailto:william.reade@canonical.com" target="_blank">william.reade@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">worker/uniter/operation/<wbr>runcommands.go:68... uses `context.ErrReboot` to indicate "there is a valid response value that should be handled, but we also need to queue a reboot". The change throws away the valid response.<br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 11, 2016 at 1:47 AM, Martin Packman <span dir="ltr"><<a href="mailto:martin.packman@canonical.com" target="_blank">martin.packman@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Nicholas was struggling today to land his snapcraft pull request:<br>
<br>
<<a href="https://github.com/juju/juju/pull/5956" rel="noreferrer" target="_blank">https://github.com/juju/juju/<wbr>pull/5956</a>><br>
<br>
As a side effect this updates some dependencies, including a couple of<br>
changes to juju/utils, which it turns out, causes<br>
UniterSuite.TestRebootFromJuju<wbr>Run to fail.<br>
<br>
Here's a run of master, which passes:<br>
<br>
<<a href="http://paste.ubuntu.com/22963025/" rel="noreferrer" target="_blank">http://paste.ubuntu.com/22963<wbr>025/</a>><br>
<br>
Then the failure, just with utils updated to rev 8a9dea0:<br>
<br>
<<a href="http://paste.ubuntu.com/22965595/" rel="noreferrer" target="_blank">http://paste.ubuntu.com/22965<wbr>595/</a>><br>
<br>
I'm not clear on how the new exec behaviour is actually causing the<br>
test failure:<br>
<br>
<<a href="https://github.com/juju/utils/pull/203/files" rel="noreferrer" target="_blank">https://github.com/juju/utils<wbr>/pull/203/files</a>><br>
<br>
So, any insights or suggestions welcome.<br>
<br>
<br>
Note, the log also includes two other errors, but they appear in both<br>
the passing and failing log, so are not actually affecting the test<br>
outcome:<br>
<br>
[LOG] 0:01.631 ERROR juju.apiserver Unable to prime<br>
/tmp/check-1447535164350529303<wbr>/5/logsink.log (proceeding anyway):<br>
chown /tmp/check-1447535164350529303<wbr>/5/logsink.log: operation not<br>
permitted<br>
<br>
This code should probably just not be being run under unit test, is<br>
assuming root privs?<br>
<br>
[LOG] 0:03.078 ERROR juju.worker.uniter.context updating agent status:<br>
cannot set invalid status "rebooting"<br>
<br>
The status setting code in uniter is a twisty confusion, I don't know<br>
why this is happening or where the error is being swallowed.<br>
<span><font color="#888888"><br>
Martin<br>
<br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailm<wbr>an/listinfo/juju-dev</a><br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>