<div dir="ltr">worker/uniter/operation/runcommands.go:68... uses `context.ErrReboot` to indicate "there is a valid response value that should be handled, but we also need to queue a reboot". The change throws away the valid response. </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Aug 11, 2016 at 1:47 AM, Martin Packman <<a href="mailto:martin.packman@canonical.com" target="_blank">martin.packman@canonical.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Nicholas was struggling today to land his snapcraft pull request: <<a href="https://github.com/juju/juju/pull/5956" rel="noreferrer" target="_blank">https://github.com/juju/juju/pull/5956</a>> As a side effect this updates some dependencies, including a couple of changes to juju/utils, which it turns out, causes UniterSuite.TestRebootFromJujuRun to fail. Here's a run of master, which passes: <<a href="http://paste.ubuntu.com/22963025/" rel="noreferrer" target="_blank">http://paste.ubuntu.com/22963025/</a>> Then the failure, just with utils updated to rev 8a9dea0: <<a href="http://paste.ubuntu.com/22965595/" rel="noreferrer" target="_blank">http://paste.ubuntu.com/22965595/</a>> I'm not clear on how the new exec behaviour is actually causing the test failure: <<a href="https://github.com/juju/utils/pull/203/files" rel="noreferrer" target="_blank">https://github.com/juju/utils/pull/203/files</a>> So, any insights or suggestions welcome. Note, the log also includes two other errors, but they appear in both the passing and failing log, so are not actually affecting the test outcome: [LOG] 0:01.631 ERROR juju.apiserver Unable to prime /tmp/check-1447535164350529303/5/logsink.log (proceeding anyway): chown /tmp/check-1447535164350529303/5/logsink.log: operation not permitted This code should probably just not be being run under unit test, is assuming root privs? [LOG] 0:03.078 ERROR juju.worker.uniter.context updating agent status: cannot set invalid status "rebooting" The status setting code in uniter is a twisty confusion, I don't know why this is happening or where the error is being swallowed. Martin -- Juju-dev mailing list <a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> </blockquote></div> </div>