<p dir="ltr">I agree with Horacio, forget controller is good becsude it only does what you expect, whereas failing to kill a controller but making it look like success is bad.</p> <p dir="ltr">Honestly, I think the problem is kill controller that should just go back to being a flag on destroy controller. Then we'd just have destroy and forget. </p> <br><div class="gmail_quote"><div dir="ltr">On Wed, Apr 6, 2016, 6:59 AM Horacio Duran <<a href="mailto:horacio.duran@canonical.com">horacio.duran@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The issue I see with that approach is that in that case kill-controller might be doing less than you expect instead of more, suppose the controller is having transient issues and kill controller cannot reach the cloud for deletion, this would forget the controller and leave it in the cloud, forget-controller instead tells us very clearly what is going to happen, the change is going to be local and not affect the controller.<div>My 2c</div><div><br><br>On Wednesday, 6 April 2016, Nick Veitch <<a href="mailto:nick.veitch@canonical.com" target="_blank">nick.veitch@canonical.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">just my tuppence<div><br></div><div>instead of having another command, can't we just add this as an option to kill-controller?</div><div><br></div><div>juju kill-controller --cleanup <controller></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 6 April 2016 at 11:05, Horacio Duran <span dir="ltr"><<a>horacio.duran@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>I might be biased by years of apt-get but purge makes me think that you are going to do what kill is supposed to do, forget sound more aligned whit what you are really aiming to.<div><div><div><br>On Wednesday, 6 April 2016, Andrew Wilkins <<a>andrew.wilkins@canonical.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Tue, Apr 5, 2016 at 2:29 AM Cheryl Jennings <<a>cheryl.jennings@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Relevant bug: <a href="https://bugs.launchpad.net/juju-core/+bug/1553059" target="_blank">https://bugs.launchpad.net/juju-core/+bug/1553059</a><div><br></div><div>We should provide a way to clean up controllers without making the user manually edit juju's files.</div></div></blockquote><div><br></div><div>Unless anyone objects, or has a better spelling, I will be adding a command to do this:</div><div><br></div><div> juju purge-controller <controller-name></div><div><br></div><div>The command will require a "-y" or prompt for confirmation, like kill-controller. It will not attempt to destroy the controller, it will just remove the details of it from the client.</div><div><br></div><div>(Alternative suggestion for spelling: "juju forget-controller". Purge-controller may suggest that we're purging a controller of its contents, rather than purging the controller from the client?)</div><div><br></div><div>Cheers,</div><div>Andrew</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 4, 2016 at 7:05 AM, Nate Finch <span dir="ltr"><<a>nate.finch@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This just happened to me, too. Kill-controller needs to work if at all possible. That's the whole point. And yes, users may not hit specific problems, but devs do, and that wastes our time trying to figure out how to manually clean up the garbage.</div><br><div class="gmail_quote"><div><div><div dir="ltr">On Mon, Apr 4, 2016 at 8:33 AM Rick Harding <<a>rick.harding@canonical.com</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Sun, Apr 3, 2016 at 6:56 PM Andrew Wilkins <<a>andrew.wilkins@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">In a non-beta release we would make sure that the config changes aren't backwards incompatible.</div></div></div></blockquote><div><br></div></div></div><div dir="ltr"><div class="gmail_quote"><div>I think this is the key thing. I think that kill-controller is an exception to this rule. I think we should always at least give the user the ability to remove their stuff and start over with the new alpha/beta/rc release. I'd like to ask us to explore making kill-controller an exception to this policy and that if tests prove we can't bootstrap on one beta and kill with trunk that it's a blocking bug for us. </div></div></div></div></div><span> --<br> Juju-dev mailing list<br> <a>Juju-dev@lists.ubuntu.com</a><br> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> </span></blockquote></div> <br>--<br> Juju-dev mailing list<br> <a>Juju-dev@lists.ubuntu.com</a><br> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> <br></blockquote></div><br></div> </blockquote></div></div> </blockquote></div> </div></div><br>--<br> Juju-dev mailing list<br> <a>Juju-dev@lists.ubuntu.com</a><br> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> <br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div>Nick Veitch, </div><div>CDO Documentation<br></div><div>Canonical</div></div></div></div></div> </div> </blockquote></div> --<br> Juju-dev mailing list<br> <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> </blockquote></div>