I obviously wasn't clear. I was suggesting a --yes-i-really-mean-it flag on kill-controller, but if you passed just -y we show the prompt anyway (instead of erroring out on an unknown flsg). My point with the big prompt was in response to Rick saying it should never be needed and should only be used in extreme circumstances... If that's how we feel, we should make sure the user knows it. Many people have said on this thread that the difference between kill-controller and destroy-controller is not immediately obvious.., and we're the devs on the project. I'm just trying to make sure we make it clear for users. <div class="gmail_quote"><div dir="ltr">On Wed, Apr 6, 2016, 4:54 PM Tim Penhey <<a href="mailto:tim.penhey@canonical.com">tim.penhey@canonical.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 06/04/16 23:13, Nick Veitch wrote: > Sure, I am just concerned about a proliferation of commands to do the > same (ultimately) task > > destroy-controller The most correct way to take down a controller. > kill-controller The OMG it is broken, please do as much as you can and I know I'm going to have to manually check any resources left around that it couldn't clean up. > forget/purge-controller Remove local references to the controller. Not really the same things at all. Tim > > > > On 6 April 2016 at 11:59, Horacio Duran <<a href="mailto:horacio.duran@canonical.com" target="_blank">horacio.duran@canonical.com</a> > <mailto:<a href="mailto:horacio.duran@canonical.com" target="_blank">horacio.duran@canonical.com</a>>> wrote: > >Â Â Â The issue I see with that approach is that in that case >Â Â Â kill-controller might be doing less than you expect instead of more, >Â Â Â suppose the controller is having transient issues and kill >Â Â Â controller cannot reach the cloud for deletion, this would forget >Â Â Â the controller and leave it in the cloud, forget-controller instead >Â Â Â tells us very clearly what is going to happen, the change is going >Â Â Â to be local and not affect the controller. >Â Â Â My 2c > > >Â Â Â On Wednesday, 6 April 2016, Nick Veitch <<a href="mailto:nick.veitch@canonical.com" target="_blank">nick.veitch@canonical.com</a> >Â Â Â <mailto:<a href="mailto:nick.veitch@canonical.com" target="_blank">nick.veitch@canonical.com</a>>> wrote: > >Â Â Â Â Â just my tuppence > >Â Â Â Â Â instead of having another command, can't we just add this as an >Â Â Â Â Â option to kill-controller? > >Â Â Â Â Â juju kill-controller --cleanup <controller> > > > >Â Â Â Â Â On 6 April 2016 at 11:05, Horacio Duran >Â Â Â Â Â <<a href="mailto:horacio.duran@canonical.com" target="_blank">horacio.duran@canonical.com</a>> wrote: > > >Â Â Â Â Â Â Â I might be biased by years of apt-get but purge makes me >Â Â Â Â Â Â Â think that you are going to do what kill is supposed to do, >Â Â Â Â Â Â Â forget sound more aligned whit what you are really aiming to. > >Â Â Â Â Â Â Â On Wednesday, 6 April 2016, Andrew Wilkins >Â Â Â Â Â Â Â <<a href="mailto:andrew.wilkins@canonical.com" target="_blank">andrew.wilkins@canonical.com</a>> wrote: > >Â Â Â Â Â Â Â Â Â On Tue, Apr 5, 2016 at 2:29 AM Cheryl Jennings >Â Â Â Â Â Â Â Â Â <<a href="mailto:cheryl.jennings@canonical.com" target="_blank">cheryl.jennings@canonical.com</a>> wrote: > >Â Â Â Â Â Â Â Â Â Â Â Relevant bug: >Â Â Â Â Â Â Â Â Â Â Â <a href="https://bugs.launchpad.net/juju-core/+bug/1553059" rel="noreferrer" target="_blank">https://bugs.launchpad.net/juju-core/+bug/1553059</a> > >Â Â Â Â Â Â Â Â Â Â Â We should provide a way to clean up controllers >Â Â Â Â Â Â Â Â Â Â Â without making the user manually edit juju's files. > > >Â Â Â Â Â Â Â Â Â Unless anyone objects, or has a better spelling, I will >Â Â Â Â Â Â Â Â Â be adding a command to do this: > >Â Â Â Â Â Â Â Â Â Â Â juju purge-controller <controller-name> > >Â Â Â Â Â Â Â Â Â The command will require a "-y" or prompt for >Â Â Â Â Â Â Â Â Â confirmation, like kill-controller. It will not attempt >Â Â Â Â Â Â Â Â Â to destroy the controller, it will just remove the >Â Â Â Â Â Â Â Â Â details of it from the client. > >Â Â Â Â Â Â Â Â Â (Alternative suggestion for spelling: "juju >Â Â Â Â Â Â Â Â Â forget-controller". Purge-controller may suggest that >Â Â Â Â Â Â Â Â Â we're purging a controller of its contents, rather than >Â Â Â Â Â Â Â Â Â purging the controller from the client?) > >Â Â Â Â Â Â Â Â Â Cheers, >Â Â Â Â Â Â Â Â Â Andrew > >Â Â Â Â Â Â Â Â Â Â Â On Mon, Apr 4, 2016 at 7:05 AM, Nate Finch >Â Â Â Â Â Â Â Â Â Â Â <<a href="mailto:nate.finch@canonical.com" target="_blank">nate.finch@canonical.com</a>> wrote: > >Â Â Â Â Â Â Â Â Â Â Â Â Â This just happened to me, too.Â Kill-controller >Â Â Â Â Â Â Â Â Â Â Â Â Â needs to work if at all possible.Â That's the >Â Â Â Â Â Â Â Â Â Â Â Â Â whole point.Â And yes, users may not hit >Â Â Â Â Â Â Â Â Â Â Â Â Â specific problems, but devs do, and that wastes >Â Â Â Â Â Â Â Â Â Â Â Â Â our time trying to figure out how to manually >Â Â Â Â Â Â Â Â Â Â Â Â Â clean up the garbage. > >Â Â Â Â Â Â Â Â Â Â Â Â Â On Mon, Apr 4, 2016 at 8:33 AM Rick Harding >Â Â Â Â Â Â Â Â Â Â Â Â Â <<a href="mailto:rick.harding@canonical.com" target="_blank">rick.harding@canonical.com</a>> wrote: > >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â On Sun, Apr 3, 2016 at 6:56 PM Andrew >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Wilkins <<a href="mailto:andrew.wilkins@canonical.com" target="_blank">andrew.wilkins@canonical.com</a>> wrote: > >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â In a non-beta release we would make sure >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â that the config changes aren't backwards >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â incompatible. > > >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â I think this is the key thing. I think that >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â kill-controller is an exception to this >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â rule. I think we should always at least give >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â the user the ability to remove their stuff >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â and start over with the new alpha/beta/rc >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â release. I'd like to ask us to explore >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â making kill-controller an exception to this >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â policy and that if tests prove we can't >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â bootstrap on one beta and kill with trunk >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â that it's a blocking bug for us. >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â -- >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Juju-dev mailing list >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a> >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Modify settings or unsubscribe at: >Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> > > >Â Â Â Â Â Â Â Â Â Â Â Â Â -- >Â Â Â Â Â Â Â Â Â Â Â Â Â Juju-dev mailing list >Â Â Â Â Â Â Â Â Â Â Â Â Â <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a> >Â Â Â Â Â Â Â Â Â Â Â Â Â Modify settings or unsubscribe at: >Â Â Â Â Â Â Â Â Â Â Â Â Â <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> > > > >Â Â Â Â Â Â Â -- >Â Â Â Â Â Â Â Juju-dev mailing list >Â Â Â Â Â Â Â <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a> >Â Â Â Â Â Â Â Modify settings or unsubscribe at: >Â Â Â Â Â Â Â <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> > > > > >Â Â Â Â Â -- >Â Â Â Â Â Nick Veitch, >Â Â Â Â Â CDO Documentation >Â Â Â Â Â Canonical > > > > > -- > Nick Veitch, > CDO Documentation > Canonical > > -- Juju-dev mailing list <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> </blockquote></div>