<div dir="ltr">Sorry for the lack of tests for that part of the code, I guess I added them for one and not the other. Note that I had actually been leaving that PR unmerged because I knew master was blocked. Sorry it got pushed in anyway, and caused problems.</div><div class="gmail_extra"> <div class="gmail_quote">On Mon, May 4, 2015 at 7:20 PM, Martin Packman <<a href="mailto:martin.packman@canonical.com" target="_blank">martin.packman@canonical.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There was some confusion about the regression to the windows test failures on trunk. <<a href="https://bugs.launchpad.net/juju-core/+bug/1450919" target="_blank">https://bugs.launchpad.net/juju-core/+bug/1450919</a>> Partly my fault, Curtis initially looked at the 1.24 branch and I looked at trunk, and each branch has a different issue. Here's what I've just done to diagnose. So, trunk first, I noticed the failures looked exactly the same as before CI fiddled with the environment variable casing to work around a juju bug: <<a href="https://launchpad.net/bugs/1446871" target="_blank">https://launchpad.net/bugs/1446871</a>> The fix for this bug landed on master, therefore it's easy to assume that change actually broke the casing behaviour in such a way as to invalidate the CI hack, rather than fixing the underlying issue. Looking at the code: <<a href="https://github.com/juju/juju/pull/2124/files" target="_blank">https://github.com/juju/juju/pull/2124/files</a>> Two similar functions now exist for merging case, mergeEnvWin which works on map[string]string and mergeWindowsEnvironment which works on []string. Only mergeEnvWin has tests. Guess, mergeWindowsEnvironment is bugged. Indeed: - m[strings.ToUpper(varSplit[0])] = varSplit[1] + k := varSplit[0] + if _, ok := uppers[strings.ToUpper(k)]; ok { + uppers[k] = varSplit[1] It's not uppercasing the key in the assignment. So, Path is matched to PATH, Path is assigned to, but later only PATH is pulled out. Now for the 1.24 branch, no hints here. So, lets see what changed. Latest working 1.24 without windows test failures: <<a href="http://reports.vapour.ws/releases/2581" target="_blank">http://reports.vapour.ws/releases/2581</a>> Earliest 1.24 with windows test failures: <<a href="http://reports.vapour.ws/releases/2592" target="_blank">http://reports.vapour.ws/releases/2592</a>> $ git diff fffe3e4f..95e7619f 2770 lines... Not helpful. But, error mentions "cannot move the charm archive" and: -<a href="http://gopkg.in/juju/charm.v5" target="_blank">gopkg.in/juju/charm.v5</a> git 6b74a2771545912f8a91a544b0f28405b9938624 2015-04-14T14:33:47Z +<a href="http://gopkg.in/juju/charm.v5" target="_blank">gopkg.in/juju/charm.v5</a> git 779394167ac61b02ca73ca17c3012f05a5ba316c 2015-04-30T02:46:55Z $ pushd ~/go/src/<a href="http://gopkg.in/juju/charm.v5" target="_blank">gopkg.in/juju/charm.v5</a> Try to update and branches diverged? Wha? $ git diff 6b74a277..77939416 Er... this includes a revert of my licence header changes, and, the answer to the test failures, Gabriel's file closing fix: <<a href="https://github.com/juju/charm/pull/119" target="_blank">https://github.com/juju/charm/pull/119</a>> <<a href="https://github.com/juju/charm/pull/120" target="_blank">https://github.com/juju/charm/pull/120</a>> So, just renaming a variable is *not* safe (if you accidentally back out other changes when merging). Both these regressions happened due to landing 'safe' changes while the branch was broken, and were therefore harder to pin down than they would otherwise have been. Martin -- Juju-dev mailing list <a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> </blockquote></div> </div>