<div dir="ltr">I wasn't able to work out why my test failed on windows, but I was able to realise that it wasn't really testing what I wanted. I'm landing a further change now that makes the tests a little better, and adds a new one, and I've confirmed that they pass in the right way on windows and ubuntu.<div><br></div><div>Matty</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 24, 2015 at 11:43 AM, John Meinel <span dir="ltr"><<a href="mailto:john@arbash-meinel.com" target="_blank">john@arbash-meinel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">That's really great!<div><br></div><div>John</div><div>=:-></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 24, 2015 at 1:59 PM, Gabriel Samfira <span dir="ltr"><<a href="mailto:gsamfira@cloudbasesolutions.com" target="_blank">gsamfira@cloudbasesolutions.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">That is great news! Congrats guys! :)<br>
<br>
<br>
Cheers,<br>
Gabriel<br>
________________________________________<br>
From: <a href="mailto:juju-dev-bounces@lists.ubuntu.com" target="_blank">juju-dev-bounces@lists.ubuntu.com</a> [<a href="mailto:juju-dev-bounces@lists.ubuntu.com" target="_blank">juju-dev-bounces@lists.ubuntu.com</a>] on behalf of Martin Packman [<a href="mailto:martin.packman@canonical.com" target="_blank">martin.packman@canonical.com</a>]<br>
Sent: Friday, April 24, 2015 12:56 PM<br>
To: <a href="mailto:juju-dev@lists.ubuntu.com" target="_blank">juju-dev@lists.ubuntu.com</a><br>
Subject: Re: Test suite on windows now voting on trunk<br>
<div><div><br>
On 23/04/2015, Martin Packman <<a href="mailto:martin.packman@canonical.com" target="_blank">martin.packman@canonical.com</a>> wrote:<br>
> Well, mostly good news after Matty and I landed workarounds. There's a<br>
> single remaining failure that has manifested since:<br>
><br>
> TestLeadership fails on windows test slave<br>
> <<a href="https://bugs.launchpad.net/juju-core/+bug/1447595" target="_blank">https://bugs.launchpad.net/juju-core/+bug/1447595</a>><br>
<br>
With Bogdan's fix landed, we've had our first clean run on CI:<br>
<br>
<<a href="http://reports.vapour.ws/releases/2558/job/run-unit-tests-win2012-amd64/attempt/287" target="_blank">http://reports.vapour.ws/releases/2558/job/run-unit-tests-win2012-amd64/attempt/287</a>><br>
<br>
Description set: Revision build: 2558<br>
gitbranch:master:<a href="http://github.com/juju/juju" target="_blank">github.com/juju/juju</a> 73cde95d<br>
Finished: SUCCESS<br>
<br>
Thanks for helping out everyone!<br>
<br>
Martin<br>
<br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
<br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
<br></blockquote></div><br></div>