<div dir="ltr">I like the idea. Thinking out loud: do we want to combine this with "the wrench" so that we have 1 consistent way to fiddle with Juju behavior?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 25, 2014 at 4:47 PM, Tim Penhey <span dir="ltr"><<a href="mailto:tim.penhey@canonical.com" target="_blank">tim.penhey@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
There are often times when we want to hook up features for testing that<br>
we don't want exposed to the general user community.<br>
<br>
In the past we have hooked things up in master, then when the release<br>
branch is made, we have had to go and change things there. This is a<br>
terrible way to do it.<br>
<br>
Here is my proposal:<br>
<br>
<a href="http://reviews.vapour.ws/r/531/diff/#" target="_blank">http://reviews.vapour.ws/r/531/diff/#</a><br>
<br>
We have an environment variable called JUJU_FEATURE_FLAGS. It contains<br>
comma delimited strings that are used as flags.<br>
<br>
The value is read when the program initializes and is not mutable.<br>
<br>
Simple checks can be used in the code:<br>
<br>
if featureflag.Enabled("foo") {<br>
// do foo like things<br>
}<br>
<br>
Thoughts and suggestions appreciated, but I don't want to have the<br>
bike-shedding go on too long.<br>
<span class="HOEnZb"><font color="#888888"><br>
Tim<br>
<br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
</font></span></blockquote></div><br></div>