We should change the make target to always run and change the CI machines so they can run it, and test that dependencies.tsv is correct. It's crazy that we don't do that now. The only reason the build even works now is a happy accident (and constant fixes to dependencies.tsv when it breaks) <div class="gmail_quote">On Oct 29, 2014 5:01 PM, "Tim Penhey" <<a href="mailto:tim.penhey@canonical.com">tim.penhey@canonical.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 29/10/14 21:05, Dimiter Naydenov wrote: > On 29.10.2014 09:46, David Cheney wrote: >> Does your $GOPATH include more than one entry ? > No, it only has a single path. > > >> The make target should probably just expect godeps to be in your >> $PATH. > That's a good point. I did some experiments adding: > GODEPS := $(shell which godeps) > > at the beginning and then trying to use it. I found out what the > problem was - apparently the Makefile was written with the idea that > godeps shouldn't be called unless JUJU_MAKE_GODEPS is set to true. > > With the following patch, I can now run "make godeps" and related > targets without an issue: The reason for the "default off" switch was due to the CI builders and test machines. We need to be a little careful here. When this came out yesterday, I tried to run godeps with the flag specified above to make the makefile just work, but since I didn't have the repo at all, it just failed. And I stopped working on it and threw away the branch. Happy to review makefile changes though. Tim -- Juju-dev mailing list <a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> </blockquote></div>