<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Ok, that would work.<br>
<br>
Doing it how you explained would probably suppose that we have to at least update the packages that make the tests fail in dependencies.tsv but we should eventually update all packages that use gocheck. This needs to happen at some point anyway because otherwise
we can't bring updates from gocheck into anything really, if it's maintained on github now and we aren't using that. I'd rather see it happening sooner rather than later, it's just going to get harder if it also gets up to a point where it breaks functionality
as well.<br>
<br>
We might be able to add the changes so only that commit gets pulled, but that depends on how godeps is implemented and I'm not completely sure if that would work.<br>
<br>
Bogdan<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF551120"><font color="#000000" face="Tahoma" size="2"><b>From:</b> John Meinel [john@arbash-meinel.com]<br>
<b>Sent:</b> Friday, September 05, 2014 5:29 AM<br>
<b>To:</b> Bogdan Teleaga<br>
<b>Cc:</b> juju-dev@lists.ubuntu.com<br>
<b>Subject:</b> RE: Changing gocheck fetch url<br>
</font><br>
</div>
<div></div>
<div>
<p dir="ltr">So it isnt the name change per say, even if they were the same name you'd get type errors due to a different import path.<br>
It doesn't matter if they all land at the same time. All of the dependencies can be updated and the test suites should pass in all of their trunks. In juju-core we won't have changes dependencies.tsv yet so when you use godeps to bring in the right version,
the tests will still pass on juju-core trunk. And when the dependencies are ready we update the world with a updated dependencies.tsv in the same commit that changes our go check library.
</p>
<p dir="ltr">Now the question remains... changing an import like this is very incompatible for everyone else but only in your test suite. Does that mean we should be bumping the import version for all packages?</p>
<p dir="ltr">John<br>
=:-></p>
<div class="gmail_quote">On Sep 4, 2014 9:29 PM, "Bogdan Teleaga" <<a href="mailto:bteleaga@cloudbasesolutions.com" target="_blank">bteleaga@cloudbasesolutions.com</a>> wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">The main problem with this approach is the fact that there are still dependencies between the packages that are not fulfilled.<br>
Mainly because the package name has been changed from gocheck to check<span></span><span></span>, I get lots of type errors when updating dependencies by themselves.<br>
What works so far is replacing everything under juju + the <a href="http://gopkg.in/juju/charm.v3" target="_blank">
gopkg.in/juju/charm.v3</a> package which also causes some trouble. As long as they're updated at the same time, the tests continue to run perfectly.
<br>
<br>
Any ideas on how we might achieve this? I think simply putting up PR's on each repo isn't feasible since they won't be merged at the same time.<br>
<br>
Bogdan<br>
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<hr>
<div style="direction:ltr"><font color="#000000" face="Tahoma"><b>From:</b> John Meinel [<a href="mailto:john@arbash-meinel.com" target="_blank">john@arbash-meinel.com</a>]<br>
<b>Sent:</b> Thursday, September 04, 2014 8:02 AM<br>
<b>To:</b> Bogdan Teleaga<br>
<b>Cc:</b> <a href="mailto:juju-dev@lists.ubuntu.com" target="_blank">juju-dev@lists.ubuntu.com</a><br>
<b>Subject:</b> Re: Changing gocheck fetch url<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">I would migrate things over one at a time, as there shouldn't be dependencies between them (test suites are run in a separate process for every package). There is likely to be some "testing" packages that are used in multiple packages, but that
should all be in the juju-core layer. There might be some test harnesses from other dependencies, but we have proper lock-step dependency management already.
<div><br>
So my suggestion is to put up proposals for the dependencies, land them, then update juju-core and dependencies.tsv at the same time, and everything should go smoothly.</div>
<div><br>
</div>
<div>John</div>
<div>=:-></div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Sep 3, 2014 at 7:05 PM, Bogdan Teleaga <span dir="ltr">
<<a href="mailto:bteleaga@cloudbasesolutions.com" target="_blank">bteleaga@cloudbasesolutions.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Hey,<br>
<br>
It seems that gocheck is still updated from <a href="https://launchpad.net/gocheck." target="_blank">
https://launchpad.net/gocheck.</a> However, as you can see if you check the page the project has moved to github(<a href="https://github.com/go-check/check" target="_blank">https://github.com/go-check/check</a>) and this results in us not having the latest
updates.<br>
So far I've tried doing a global sed in a backup go/src directory and everything seems to be working fine test-wise. However we need to commit everything in the respective repositories for godeps to work correctly. Is there any particular way we should go about
doing this? I can get patches ready for every particular repo if needed.<span><font color="#888888"><br>
<br>
Bogdan<br>
</font></span></div>
</div>
<br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">
https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>