<p dir="ltr">What happens when you run godeps normally? </p>
<p dir="ltr">It should ignore the std lib stuff, but I don't actually know how that's implemented.</p>
<div class="gmail_quote">On Aug 20, 2014 8:02 PM, "Ian Booth" <<a href="mailto:ian.booth@canonical.com">ian.booth@canonical.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hmmmm. The test fails for me.<br>
<br>
<br>
FAIL: dependencies_test.go:42: dependenciesTest.TestGodepsIsRight<br>
<br>
dependencies_test.go:77:<br>
...<br>
dependencies_test.go:70:<br>
c.Fatal(string(out))<br>
... Error: godeps: no version control system found for "/usr/lib/go/src/pkg/bufio"<br>
godeps: no version control system found for "/usr/lib/go/src/pkg/bytes"<br>
godeps: no version control system found for "/usr/lib/go/src/pkg/errors"<br>
godeps: no version control system found for "/usr/lib/go/src/pkg/io"<br>
godeps: no version control system found for "/usr/lib/go/src/pkg/sync"<br>
godeps: no version control system found for "/usr/lib/go/src/pkg/sync/atomic"<br>
...<br>
...<br>
<br>
<br>
On 21/08/14 05:18, Nate Finch wrote:<br>
> In an effort to make sure that dependencies.tsv is actually correct, the<br>
> tests in <a href="http://github.com/juju/juju" target="_blank">github.com/juju/juju</a> now run godeps -t ./... and compare its<br>
> output to dependencies.tsv. The test looks for godeps first in the $PATH,<br>
> and then in the first $GOPATH/bin. If it is not found, it currently skips<br>
> the test (because CI doesn't have godeps when it runs the tests).<br>
> Eventually I'd like to make the test not skippable, since anyone running<br>
> the tests (except CI) needs godeps anyway... but to get this in sooner<br>
> rather than later, I think it's ok to let it be skipped.<br>
><br>
> Note that in submitting the PR, I actually had to fix dependencies.tsv to<br>
> get the test to pass, because it was wrong.... which is exactly why this<br>
> test exists.<br>
><br>
> You can now run go test from <a href="http://github.com/juju/juju" target="_blank">github.com/juju/juju</a> and it'll tell you if<br>
> something's wonky with dependencies.tsv... it'll tell you if there are<br>
> entries in it that aren't needed, it'll tell you if you're missing entries<br>
> that should be in it, and it'll tell you if one of your branches is on the<br>
> wrong commit.<br>
><br>
> *Note:* this means you can't just willy-nilly append your latest dependency<br>
> to dependencies.tsv. They need to be in alphabetical order. The easiest<br>
> way to do that is just to run godeps -t ./... > dependencies.tsv from<br>
> <a href="http://github.com/juju/juju" target="_blank">github.com/juju/juju</a>. That'll produce the right output. Obviously, check<br>
> the diff to make sure the changes it produces are the ones you expect.<br>
><br>
> This also means that we need to ensure godeps produces the right output on<br>
> all OSes. If you have a dependency that exists only in an OS-specific<br>
> file, the godeps test will fail on OSes other than that one (e.g. if<br>
> there's a dependency in an _windows.go file, the test will fail on linux,<br>
> because godeps doesn't see the windows dependencies). To fix this, the<br>
> easiest thing to do is import the same library in an OS-agnostic file, and<br>
> give it a name of underscore, which will prevent the unused package error,<br>
> thusly: _ "<a href="http://foo.com/my/win/lib" target="_blank">foo.com/my/win/lib</a>"<br>
><br>
> -Nate<br>
><br>
><br>
><br>
<br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
</blockquote></div>