<div dir="ltr">Ok, so the behavior would have to be:<div>opened ports : 80-100</div><div><br></div><div>close ports 60-70 -> no error (noop)</div><div>close ports 60-90 -> error (cannot close part of a port range)</div> <div>close ports 80-100 -> no error</div><div><br></div><div>I'm starting to think this scenario is preferrable, especially with respect to the idempotency of charm hooks.</div><div><br></div><div>Domas</div></div> <div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 5, 2014 at 2:45 PM, Kapil Thangavelu <span dir="ltr"><<a href="mailto:kapil.thangavelu@canonical.com" target="_blank">kapil.thangavelu@canonical.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">imo, no, its a no-op. the end state is still the same. if its an error, and now we have partial failure modes to consider against ranges.<br> <br><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote"> On Tue, Aug 5, 2014 at 1:25 PM, David Cheney <span dir="ltr"><<a href="mailto:david.cheney@canonical.com" target="_blank">david.cheney@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Yes, absolutely.<br> <div><div><br> On Tue, Aug 5, 2014 at 8:33 PM, Domas Monkus <<a href="mailto:domas.monkus@canonical.com" target="_blank">domas.monkus@canonical.com</a>> wrote:<br> > A follow-up question: should closing a port that was not opened previous to<br> > that result in an error?<br> ><br> > Domas<br> ><br> ><br> > On Fri, Jun 27, 2014 at 2:13 PM, Matthew Williams<br> > <<a href="mailto:matthew.williams@canonical.com" target="_blank">matthew.williams@canonical.com</a>> wrote:<br> >><br> >> +1 on an opened-ports hook tool, I've added it to the task list<br> >><br> >><br> >> On Fri, Jun 27, 2014 at 9:41 AM, William Reade<br> >> <<a href="mailto:william.reade@canonical.com" target="_blank">william.reade@canonical.com</a>> wrote:<br> >>><br> >>> Agreed. Note, though, that we'll want to give charms a way to know what<br> >>> ports they have already opened: I think this is a case where<br> >>> look-before-you-leap maybe beats easier-ask-forgiveness-than-permission (and<br> >>> the consequent requirement that error messages be parsed...). An<br> >>> opened-ports hook tool should do the trick.<br> >>><br> >>><br> >>> On Thu, Jun 26, 2014 at 9:18 PM, Gustavo Niemeyer <<a href="mailto:gustavo@niemeyer.net" target="_blank">gustavo@niemeyer.net</a>><br> >>> wrote:<br> >>>><br> >>>> +1 to Mark's point. Handling exact matches is much easier, and does<br> >>>> not prevent a fancier feature later, if there's ever the need.<br> >>>><br> >>>> On Thu, Jun 26, 2014 at 3:38 PM, Mark Ramm-Christensen (Canonical.com)<br> >>>> <<a href="mailto:mark.ramm-christensen@canonical.com" target="_blank">mark.ramm-christensen@canonical.com</a>> wrote:<br> >>>> > My belief is that as long as the error messages are clear, and it is<br> >>>> > easy to<br> >>>> > close 8000-9000 and then open 8000-8499 and 8600-9000, we are fine.<br> >>>> > Of<br> >>>> > course it is "nicer" if we can do that automatically for you, but I<br> >>>> > don't<br> >>>> > see why we can't add that later, and I think there is a value in<br> >>>> > keeping a<br> >>>> > port-range as an atomic data-object either way.<br> >>>> ><br> >>>> > --Mark Ramm<br> >>>> ><br> >>>> ><br> >>>> > On Thu, Jun 26, 2014 at 2:11 PM, Domas Monkus<br> >>>> > <<a href="mailto:domas.monkus@canonical.com" target="_blank">domas.monkus@canonical.com</a>><br> >>>> > wrote:<br> >>>> >><br> >>>> >> Hi,<br> >>>> >> me and Matthew Williams are working on support for port ranges in<br> >>>> >> juju.<br> >>>> >> There is one question that the networking model document does not<br> >>>> >> answer<br> >>>> >> explicitly and the simplicity (or complexity) of the implementation<br> >>>> >> depends<br> >>>> >> greatly on that.<br> >>>> >><br> >>>> >> Should we only allow units to close exactly the same port ranges that<br> >>>> >> they<br> >>>> >> have opened? That is, if a unit opens the port range [8000-9000], can<br> >>>> >> it<br> >>>> >> later close ports [8500-8600], effectively splitting the previously<br> >>>> >> opened<br> >>>> >> port range in half?<br> >>>> >><br> >>>> >> Domas<br> >>>> >><br> >>>> >> --<br> >>>> >> Juju-dev mailing list<br> >>>> >> <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> >>>> >> Modify settings or unsubscribe at:<br> >>>> >> <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> >>>> >><br> >>>> ><br> >>>> ><br> >>>> > --<br> >>>> > Juju-dev mailing list<br> >>>> > <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> >>>> > Modify settings or unsubscribe at:<br> >>>> > <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> >>>> ><br> >>>><br> >>>><br> >>>><br> >>>> --<br> >>>><br> >>>> gustavo @ <a href="http://niemeyer.net" target="_blank">http://niemeyer.net</a><br> >>>><br> >>>> --<br> >>>> Juju-dev mailing list<br> >>>> <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> >>>> Modify settings or unsubscribe at:<br> >>>> <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> >>><br> >>><br> >>><br> >>> --<br> >>> Juju-dev mailing list<br> >>> <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> >>> Modify settings or unsubscribe at:<br> >>> <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> >>><br> >><br> >><br> >> --<br> >> Juju-dev mailing list<br> >> <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> >> Modify settings or unsubscribe at:<br> >> <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> >><br> ><br> ><br> > --<br> > Juju-dev mailing list<br> > <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> > Modify settings or unsubscribe at:<br> > <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> ><br> <br> --<br> Juju-dev mailing list<br> <a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br> </div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div>