<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jul 10, 2014 at 8:19 PM, James Solomon <span dir="ltr"><<a href="mailto:binary132@gmail.com" target="_blank">binary132@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi all,<div><br></div><div>I've recently added the Actions bit mentioned by Andrew to FilterSuite. I'll defintely have a look over that. We're chatting about why that might be happening. Have you seen this more than once?</div>
</div></blockquote><div><br></div><div>Thanks. I have seen it a bunch of times, but today was the first time I noticed it. I think I pulled master earlier today, but I don't recall when I had done so before.</div><div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Bodie<br><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_quote">From: <b class="gmail_sendername">Andrew Wilkins</b> <span dir="ltr"><<a href="mailto:andrew.wilkins@canonical.com" target="_blank">andrew.wilkins@canonical.com</a>></span><br>
Date: Thu, Jul 10, 2014 at 3:19 PM<br>Subject: Re: New flakey juju tests<br>To: Martin Packman <<a href="mailto:martin.packman@canonical.com" target="_blank">martin.packman@canonical.com</a>><br>Cc: "<a href="mailto:juju-dev@lists.ubuntu.com" target="_blank">juju-dev@lists.ubuntu.com</a>" <<a href="mailto:juju-dev@lists.ubuntu.com" target="_blank">juju-dev@lists.ubuntu.com</a>><div>
<div class="h5"><br>
<br><br><div dir="ltr">Here's another, that I've started seeing today:<div><br></div><div><div>FAIL: filter_test.go:508: FilterSuite.TestActionEvents</div></div><div>...</div><div><div>filter_test.go:531:</div><div>
assertChange(testIds)</div>
<div>filter_test.go:490:</div><div> c.Assert(event.ActionId, gc.Equals, id)</div><div>... obtained string = "wordpress/0_a_5"</div><div>... expected string = "wordpress/0_a_1"</div></div></div><div>
<div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Jul 9, 2014 at 5:26 PM, Martin Packman <span dir="ltr"><<a href="mailto:martin.packman@canonical.com" target="_blank">martin.packman@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
We've done a lot of work recently improving the reliability of our<br>
test suite. Unfortunately, feature work has been introducing new tests<br>
that are intermittently failing.<br>
<br>
<<a href="http://juju-ci.vapour.ws:8080/job/github-merge-juju/1/console" target="_blank">http://juju-ci.vapour.ws:8080/job/github-merge-juju/1/console</a>><br>
<br>
FAIL: machine_test.go:1750: MachineSuite.TestWatchInterfaces<br>
...<br>
machine_test.go:1808:<br>
wc.AssertOneChange()<br>
testing/watcher.go:76:<br>
c.Fatalf("watcher sent unexpected change: (_, %v)", ok)<br>
... Error: watcher sent unexpected change: (_, true)<br>
<br>
...<br>
FAIL <a href="http://github.com/juju/juju/state" target="_blank">github.com/juju/juju/state</a> 123.265s<br>
<br>
This test was added in pr 207.<br>
<br>
<<a href="https://github.com/juju/juju/pull/207" target="_blank">https://github.com/juju/juju/pull/207</a>><br>
<br>
<br>
<<a href="http://juju-ci.vapour.ws:8080/job/github-merge-juju/3/console" target="_blank">http://juju-ci.vapour.ws:8080/job/github-merge-juju/3/console</a>><br>
<br>
FAIL: server_test.go:96: serverSuite.TestAPIServerCanListenOnBothIPv4AndIPv6<br>
...<br>
server_test.go:104:<br>
c.Assert(err, gc.IsNil)<br>
... value *net.OpError = &net.OpError{Op:"listen", Net:"tcp",<br>
Addr:(*net.TCPAddr)(0xc2107e9f00),<br>
Err:(*os.SyscallError)(0xc21027f560)} ("listen tcp :54321: bind:<br>
address already in use")<br>
<br>
...<br>
FAIL <a href="http://github.com/juju/juju/state/apiserver" target="_blank">github.com/juju/juju/state/apiserver</a> 30.369s<br>
<br>
This test was added in pr 224.<br>
<br>
<<a href="https://github.com/juju/juju/pull/224" target="_blank">https://github.com/juju/juju/pull/224</a>><br>
<br>
<br>
Can we have another look at these tests and fix them up to be properly<br>
robust? I don't want to back out changes that have been in trunk for a<br>
while, but we can't leave unreliable tests on trunk. Thanks,<br>
<br>
Martin<br>
<span><font color="#888888"><br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
</font></span></blockquote></div><br></div>
</div></div><br>--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
<br></div></div></div><br></div>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div></div>