<p dir="ltr">The problem is that go get -u stomps on everything, and godeps doesn't do any fetching (you must already have the target revisions locally).<br>
Which means that potentially go get -u changes the tree we are testing. (You want a go get that updates all the dependencies, but not the main branch.)</p>
<p dir="ltr">It would be possible, but it isn't worth the time spent today, IMO.</p>
<p dir="ltr">John<br>
=:-></p>
<div class="gmail_quote">On Mar 13, 2014 1:53 AM, "Tim Penhey" <<a href="mailto:tim.penhey@canonical.com">tim.penhey@canonical.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It seems that I have mis-remembered and the bot has never done this, but<br>
the CI process has.<br>
<br>
Can we make the bot do it please?<br>
<br>
Tim<br>
<br>
On 13/03/14 10:47, Tim Penhey wrote:<br>
> Hi there,<br>
><br>
> I tried to land a branch that updated the golxc version in our<br>
> dependencies.tsv file. This used to work, and now the current bot<br>
> doesn't do it.<br>
><br>
> After a bit of poking around I find the<br>
> /home/tarmac/.config/tarmac/tarmac.conf file.<br>
><br>
> [lp:juju-core]<br>
> debug_log_location = /home/tarmac/logs/<br>
> tree_dir = /home/tarmac/trees/src/<a href="http://launchpad.net/juju-core/" target="_blank">launchpad.net/juju-core/</a><br>
> verify_command = export GOPATH=/home/tarmac/trees; go fmt ./... && go<br>
> build ./... && go test ./...<br>
><br>
><br>
> The verify_command here doesn't do either "go get -u ." nor use "godeps"<br>
> to make the tree the right revisions. Did we lose this step somewhere<br>
> in the migration to the new bot?<br>
><br>
> Can we make sure we don't lose it again?<br>
><br>
> We shouldn't have to do any more than update the dependencies file and<br>
> land the branch for the new dependencies to be added.<br>
><br>
> I haven't modified the bot myself because I'm a little vague on<br>
> ownership and who maintains the "canonical" juju-core bot deployment<br>
> details. I felt that if I just modified the bot as is, we'd lose all the<br>
> changes when we had to redeploy again, and I don't want that.<br>
><br>
> Cheers,<br>
> Tim<br>
><br>
<br>
</blockquote></div>