<div dir="ltr"><div>I've just put my finishing touches to the HP cloud branch. I'd appreciate some reviews so we can unblock 1.17.0 and CI.</div><div><br></div><div>jam: I updated Instance with a Refresh method, so the bootstrap code no longer does the refresh-under-the-covers hack</div>
<div><br></div><div>rogpeppe: I ended up doing what we briefly chatted about last night- each host checker now just attempts forever, until the Try is killed/closed. Much simpler now.</div><div>Also, if you didn't notice, I fixed <a href="https://bugs.launchpad.net/juju-core/+bug/1259942">https://bugs.launchpad.net/juju-core/+bug/1259942</a> in this branch while I was at it. The fix for that dovetailed with verifying the host's identity.</div>
<div><br></div><div>Cheers,</div><div>Andrew</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 18, 2013 at 9:02 AM, Andrew Wilkins <span dir="ltr"><<a href="mailto:andrew.wilkins@canonical.com" target="_blank">andrew.wilkins@canonical.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I started using goimports; I happened to have the shared repo in my $GOPATH.<div>Sorry - fixed that import now.<div>
<br></div><div>Cheers,</div></div><div>Andrew</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Dec 18, 2013 at 7:49 AM, David Cheney <span dir="ltr"><<a href="mailto:david.cheney@canonical.com" target="_blank">david.cheney@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Wed, Dec 18, 2013 at 10:44 AM, Curtis Hovey-Canonical <span dir="ltr"><<a href="mailto:curtis@canonical.com" target="_blank">curtis@canonical.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Tue, Dec 17, 2013 at 6:14 PM, David Cheney<br>
<<a href="mailto:david.cheney@canonical.com" target="_blank">david.cheney@canonical.com</a>> wrote:<br>
> The branch is not checked out properly.<br>
<br>
</div>I don't see this path<br>
$GOPATH/src/juju-core/ssh-options<br>
in<br>
<a href="http://bazaar.launchpad.net/~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname-take2/files" target="_blank">http://bazaar.launchpad.net/~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname-take2/files</a><br>
or<br>
trunk<br>
<br>
The make-release-tarball script<br>
<a href="http://bazaar.launchpad.net/~juju-qa/juju-core/ci-cd-scripts2/view/head:/make-release-tarball.bash" target="_blank">http://bazaar.launchpad.net/~juju-qa/juju-core/ci-cd-scripts2/view/head:/make-release-tarball.bash</a><br>
uses "go get -v -d <a href="http://launchpad.net/juju-core/.." target="_blank">launchpad.net/juju-core/..</a>."<br>
then uses bzr to force the version (and branch) to be the one under<br>
test. Finally it runs godeps to set everything to be right version.<br>
godeps is not happy.<br>
<br>
My use of a user branch is unorthodox, but I think it should work. I see in<br>
provider/common/bootstrap.go<br>
an import of<br>
"juju-core/ssh-options/utils/ssh"<br></blockquote><div><br></div></div><div>This looks wrong, the import path should be</div><div><br></div><div>import "<a href="http://launchpad.net/juju-core/utils/ssh" target="_blank">launchpad.net/juju-core/utils/ssh</a>"</div>
<div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
but looking at his branch, I would think this path is actually trying to import<br>
<a href="http://bazaar.launchpad.net/~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname-take2/view/head:/utils/ssh/ssh.go" target="_blank">http://bazaar.launchpad.net/~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname-take2/view/head:/utils/ssh/ssh.go</a><br>
<div><div><br>
--<br>
Curtis Hovey<br>
Canonical Cloud Development and Operations<br>
<a href="http://launchpad.net/~sinzui" target="_blank">http://launchpad.net/~sinzui</a><br>
<br>
--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
</div></div></blockquote></div></div><br></div></div>
<br>--<br>
Juju-dev mailing list<br>
<a href="mailto:Juju-dev@lists.ubuntu.com" target="_blank">Juju-dev@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>