Wouldnt that mean you'd want it in gocheck itself? John =:-> <div class="gmail_quote">On Aug 2, 2013 8:21 AM, "Tim Penhey" <<a href="mailto:tim.penhey@canonical.com">tim.penhey@canonical.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On 02/08/13 16:17, Ian Booth wrote: >> >> testing.PatchEnvironment >> >> This method sets the environment variable with the specified value, and >> returns a function that will set it back to what it was. Simply used in >> a test like this: >> >> defer coretesting.PatchEnvironment(osenv.JujuLxcBridge, "br0")() >> >> > > We have something similar in Goose. Which made me wonder what our policy is with > respect to collecting these sorts of useful utilities and packaging them so that > they are usable for more than just project X or Y individually. Even within > juju-core there's duplicated utility code to make up for Go's lack of this or > that feature. Usable errors is another example of Goose and juju-core solving > the same problem twice. There would be more as well I'm sure. > > Is it worth trying to do something to package this common functionality? Or will > it be too hard due to Go's lack of dependency versioning? I really am adverse to > all the DRY violations / duplication in our collective code base. > <a href="http://launchpad.net/got" target="_blank">launchpad.net/got</a> ? go t(esting) /me shrugs Makes sense to have common testing package across projects. Which would make me want to move the checkers into that too. Tim -- Juju-dev mailing list <a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> </blockquote></div>