<div dir="ltr">I vote against using a local import. I believe this is contrary to the Go orthodoxy and will hinder adoption by potential external contributors.</div><div class="gmail_extra"> <div class="gmail_quote"> On Fri, Jun 28, 2013 at 10:44 AM, Tim Penhey <<a href="mailto:tim.penhey@canonical.com" target="_blank">tim.penhey@canonical.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi All, We currently have two commonly used idioms for importing checkers. In particular "<a href="http://launchpad.net/juju-core/testing/checkers" target="_blank">launchpad.net/juju-core/testing/checkers</a>". I have the preference of importing the checkers into the local namespace so they behave in the same way as the gocheck checkers. I find this makes the tests more readable. Given that the checkers package should only be bringing in checkers and not miscellaneous functions, then I'm happy to bring them into the local namespace. This means we have: c.Assert(foo, IsTrue) c.Assert(bar.SomeFunc(), IsDirectory) I know that Roger generally disapproves and has been including the checkers package normally. This would make the above: c.Assert(foo, checkers.IsTrue) c.Assert(bar.SomeFunc(), checkers.IsDirectory) What I don't want is arbitrary changing of the imports as different people touch various parts of the codebase into their preferred format. I'd like to get a team agreement on what approach people are happy with. I'm happy to go with a majority decision either way, but I'd like the team to decide. If we don't get a quorum of response (for whatever value that may be), I'm going to defer to William as tech lead. Cheers, Tim -- Juju-dev mailing list <a href="mailto:Juju-dev@lists.ubuntu.com">Juju-dev@lists.ubuntu.com</a> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> </blockquote></div> </div>