removing colours from loggo package
Tim Penhey
tim.penhey at canonical.com
Wed Feb 22 03:31:09 UTC 2017
Tech board says "yes let's do it", I'll respond to PR.
On 22/02/17 14:15, Andrew Wilkins wrote:
> On Tue, Feb 21, 2017 at 10:02 PM roger peppe <roger.peppe at canonical.com
> <mailto:roger.peppe at canonical.com>> wrote:
>
> In August, the loggo package was changed to make it log ANSI-terminal
> colour escape sequences by default.
>
> I'm not sure that was the right decision, for a couple of reasons:
>
> - daemons are often given a pseudo tty to run in, so the log files
> produced by our running services are now obscured by escape sequences,
> making them hard to process automatically (and larger).
>
> - it means that the loggo dependencies are much larger. Where
> previously the loggo package had no non-stdlib dependencies, it now
> depends on 5 significantly sized repositories holding >100k lines of
> source, including at least one system-dependent (Windows-only) repo.
>
> I'd like to propose that we remove the colour-by-default logic from
> loggo and move it to a separate package where it can be used if
> required by a given client. Perhaps github.com/utils/loggocolor
> <http://github.com/utils/loggocolor> might
> be a reasonable place.
>
> Then we can change the juju command line client to use that writer by
> default meaning there should be no change in externally visible
> behaviour to juju client users. The jujud server executable should
> probably not be using coloured logging output IMO.
>
> Thoughts?
>
>
> Seems reasonable to me. I've added it to today's tech board agenda.
>
>
> cheers,
> rog.
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com <mailto:Juju-dev at lists.ubuntu.com>
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
>
>
More information about the Juju-dev
mailing list